Issue 1675 - Use String.trim() to strip leading and trailing whitespaces (Firefox)

chrome/content/ui/subscriptionSelection.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 221 matching lines @@
   {
     messageElement.setAttribute("invisible", "true");
     addMainCheckbox.setAttribute("invisible", "true");
   }
 }
 
 function validateURL(url)
 {
   if (!url)
     return null;
-  url = url.replace(/^\s+/, "").replace(/\s+$/, "");
+  url = url.trim();
 
   // Is this a file path?
   try {
     let file = new FileUtils.File(url);
     return Services.io.newFileURI(file).spec;
   } catch (e) {}
 
   // Is this a valid URL?
   let uri = Utils.makeURI(url);
   if (uri)
     return uri.spec;
 
   return null;
 }
 
 function addSubscription()
 {
   let url = E("location").value;
   url = validateURL(url);
   if (!url)
   {
     Utils.alert(window, Utils.getString("subscription_invalid_location"));
     E("location").focus();
     return false;
   }
 
-  let title = E("title").value.replace(/^\s+/, "").replace(/\s+$/, "");
+  let title = E("title").value.trim();
   if (!title)
     title = url;
 
   doAddSubscription(url, title);
 
   let addMainCheckbox = E("addMainSubscription")
   if (addMainCheckbox.getAttribute("invisible") != "true" && addMainCheckbox.checked)
   {
     let mainSubscriptionTitle = addMainCheckbox.getAttribute("_mainSubscriptionTitle");
     let mainSubscriptionURL = validateURL(addMainCheckbox.value);
@@ skipping 19 matching lines @@
   subscription.title = title;
 
   if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
     Synchronizer.execute(subscription);
 }
 
 function hasSubscription(url)
 {
   return FilterStorage.subscriptions.some(function(subscription) subscription instanceof DownloadableSubscription && subscription.url == url);
 }