1521 - libadblockplus is not compilable on linux x64

libadblockplus.gyp

 {
   'conditions': [[
     # We don't want to use curl on Windows and Android, skip the check there
     'OS=="win" or OS=="android"',
     {
       'variables': {
         'have_curl': 0
       }
     },
     {
       'variables': {
         'have_curl': '<!(python check_curl.py)'
       }
     }
   ]],
   'includes': ['third_party/v8/build/features.gypi',
                'third_party/v8/build/toolchain.gypi',
                'shell/shell.gyp'],
   'targets': [{
     'target_name': 'libadblockplus',
     'type': '<(library)',
+    'direct_dependent_settings':{

[Felix Dahlke, 2015/01/13 16:51:51]

There already is a direct_dependent_settings section below - why not use that?
Will having two even work as intended?

+      'defines': [
+        'werror',

[Felix Dahlke, 2015/01/13 16:51:51]

What exactly is this supposed to do? How I understand it, it just adds a
preprocessor definition called "werror". Why? I can't find anything in the v8
code looking for that.

+      ],
+      'include_dirs': [
+        'third_party/v8/include',

[Felix Dahlke, 2015/01/13 16:51:51]

This adds the v8 include path to all projects using the library - something we
explicitly avoided. Why?

+      ],
+    },
     'include_dirs': [
-      'include',
-      'third_party/v8/include',
+        'include',

[Felix Dahlke, 2015/01/13 16:51:51]

Let's stick to two space indents pleasee.

     ],
     'sources': [
       'src/AppInfoJsObject.cpp',
       'src/ConsoleJsObject.cpp',
       'src/DefaultLogSystem.cpp',
       'src/DefaultFileSystem.cpp',
       'src/FileSystemJsObject.cpp',
       'src/FilterEngine.cpp',
       'src/GlobalJsObject.cpp',
       'src/JsContext.cpp',
@@ skipping 131 matching lines @@
       'VCLinkerTool': {
         'SubSystem': '1',   # Console
         'EntryPointSymbol': 'mainCRTStartup',
       },
     },
     'xcode_settings': {
       'OTHER_LDFLAGS': ['-stdlib=libstdc++'],
     },
   }]
 }