1521 - libadblockplus is not compilable on linux x64

common.gypi

 {
   'variables': {
     'visibility%': 'hidden',
     'library%': 'static_library',
     'component%': '',
     'want_separate_host_toolset': 0,
     'v8_optimized_debug': 0,
     'v8_enable_i18n_support': 0,
   },
 
   'conditions': [
     ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
        or OS=="netbsd" or OS=="android"', {
       'target_defaults': {
-        'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',

[paco, 2015/01/14 15:15:58]

Since we're using `-Wall` the other flags are not necessary

[Wladimir Palant, 2015/01/22 15:29:21]

-W is not implied by -Wall (see
http://gcc.gnu.org/onlinedocs/gcc-3.0/gcc_3.html). Also, -Wno-unused-parameter
*suppresses* a warning. However, -Wnon-virtual-dtor seems unnecessary indeed.

[Felix Dahlke, 2015/02/02 14:12:37]

Are these changes really necessary to fix the build on 64-bit Linux? If not,
let's move them to a different review please (can be Noissue if it's just about
removing obsolete flags).

-                    '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
-                    '-pedantic', '-std=c++0x', '-fexceptions', ],
+        'cflags': [ '-Wall', '-pthread', '-fno-rtti', '-pedantic',
+                    '-std=c++0x', '-fexceptions', ],

[sergei, 2015/01/22 14:14:14]

previously there were spaces.

         'ldflags': [ '-pthread', ],
+        'cflags!': [ '-Werror', ],

[paco, 2015/01/14 15:15:58]

We're gonna see the errors but we're not treating them as erros

[Felix Dahlke, 2015/02/02 14:12:37]

I think it'd make sense to move this right below cflags - but it looks like the
proper solution indeed.

       },
     }],
     ['OS=="mac"', {
       'xcode_settings': {
         'CLANG_CXX_LANGUAGE_STANDARD': 'c++0x',
         'CLANG_CXX_LIBRARY': 'libstdc++',
         'OTHER_CPLUSPLUSFLAGS' : ['-std=c++0x', '-stdlib=libstdc++'],
       },
     }],
     ['OS=="android"', {
       'target_defaults': {
         'cflags!': [
           '-pthread',  # Not supported by Android toolchain.
         ],
         'ldflags!': [
           '-pthread',  # Not supported by Android toolchain.
         ],
       },
     }],
   ],
 
   'target_defaults': {
     'msvs_cygwin_shell': 0,
   }
 }