Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5373553692114944: Issue #430 - Filter hit counters aren't cleared (Closed)

Created:
June 9, 2014, 11:21 a.m. by saroyanm
Modified:
June 13, 2014, 9:29 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/430

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M lib/filterListener.js View 1 2 chunks +7 lines, -2 lines 0 comments Download
M lib/ui.js View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Wladimir can you please have a look, should be quick one. Thanks. http://codereview.adblockplus.org/5373553692114944/diff/5629499534213120/lib/filterStorage.js File lib/filterStorage.js ...
June 9, 2014, 11:28 a.m. (2014-06-09 11:28:02 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5373553692114944/diff/5629499534213120/lib/filterStorage.js File lib/filterStorage.js (right): http://codereview.adblockplus.org/5373553692114944/diff/5629499534213120/lib/filterStorage.js#newcode358 lib/filterStorage.js:358: let {FilterListener} = require("filterListener"); On 2014/06/09 11:28:02, saroyanm wrote: ...
June 12, 2014, 11:58 a.m. (2014-06-12 11:58:38 UTC) #2
saroyanm
Hope we can give a go with last patch. http://codereview.adblockplus.org/5373553692114944/diff/5629499534213120/lib/filterStorage.js File lib/filterStorage.js (right): http://codereview.adblockplus.org/5373553692114944/diff/5629499534213120/lib/filterStorage.js#newcode358 lib/filterStorage.js:358: ...
June 12, 2014, 4:56 p.m. (2014-06-12 16:56:02 UTC) #3
Wladimir Palant
LGTM
June 12, 2014, 6:09 p.m. (2014-06-12 18:09:16 UTC) #4
saroyanm
June 13, 2014, 9:13 a.m. (2014-06-13 09:13:44 UTC) #5
On 2014/06/12 18:09:16, Wladimir Palant wrote:
> LGTM

Deleted the patch by mistake, but have local changes. will commit, now..

Powered by Google App Engine
This is Rietveld