Issue 2516 - Add a release build script

build_release.py

 #!/usr/bin/env python
 
 import glob
 import json
 import os
 import shutil
 import subprocess
 import sys
 import tempfile
 
@@ skipping 11 matching lines @@
     raise Exception("'%s' doesn't exist, please create it." % path)
 
   with open(path) as file:
     contents = file.read()
 
   # This check can be removed once https://issues.adblockplus.org/ticket/2490 is
   # done.
   if "--disable-crashreporter" not in contents:
     raise Exception(
       "'%s' doesn't seem to set --disable-crashreporter, please do." % path)
+
+  if "export MOZILLA_OFFICIAL=1" not in contents:
+    raise Exception(
+      "'%s' doesn't seem to export MOZILLA_OFFICIAL=1, please do." % path)
 
   updater_disabled = "--disable-updater" in contents
   if updater_disabled and mode == "devbuild":
     raise Exception("'%s' seems to set --disable-updater, please don't." % path)
   elif not updater_disabled and mode == "release":
     raise Exception(
       "'%s' doesn't seem to set --disable-updater, please do." % path)
 
 def find_mozconfig(mode):

[René Jeschke, 2015/05/19 09:57:54]

Nit: 'find_mozconfig' does not really 'search' for mozconfig. Instead it just
returns a path after some validation, so the name might be misleading.

(I must admit that I would have named it likewise :-) )
(So, change it if you like, otherwise just leave it)

[Felix Dahlke, 2015/05/19 15:54:35]

Well, it looks for an appropriate mozconfig and complains if there is none. Not
brilliant I guess, but I couldn't really come up with something better.

   mozconfig_path = os.path.join(BASE_DIR, ".mozconfig-" + mode)
   check_mozconfig(mozconfig_path, mode)
   return mozconfig_path
 
 def build(mode):
   mach_environment = os.environ.copy()
   mach_environment["MOZCONFIG"] = find_mozconfig(mode)
   subprocess.check_call([MACH_PATH, "clobber"], env=mach_environment)
   subprocess.check_call([MACH_PATH, "build"], env=mach_environment)
   subprocess.check_call([MACH_PATH, "package"], env=mach_environment)
@@ skipping 28 matching lines @@
 if __name__ == "__main__":
   if len(sys.argv) < 4:
     print_usage()
     sys.exit(1)
 
   mode, key_store, key_name = sys.argv[1:]
   if mode not in ("devbuild", "release"):
     print_usage()
     sys.exit(2)
 
-  subprocess.call([ENSURE_DEPENDENCIES_PATH])

[René Jeschke, 2015/05/19 09:57:54]

Shouldn't we use 'check_call' here, too? Or is a 'ensure_dependency' failure
tolerated during a release build?

[Felix Dahlke, 2015/05/19 15:54:35]

Yes you're right. I did this by design, but for a release build we really need
to avoid this kind of issue.

+  subprocess.check_call([ENSURE_DEPENDENCIES_PATH])
   apk_path = build(mode)
   sign(apk_path, key_store, key_name)