Issue 1678 - Added bidi support for Safari

safari/ext/common.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 86 matching lines @@
       candidates.push(language + "_" + region);
 
     candidates.push(language);
 
     if (candidates.indexOf(defaultLocale) == -1)
       candidates.push(defaultLocale);
 
     return candidates;
   };
 
+  var initCatalog = function(ui_locale)
+  {
+    var bidi_dir = (ui_locale == "ar" ||
+                    ui_locale == "fa" ||
+                    ui_locale == "he" ||
+                    ui_locale == "ug" ||
+                    ui_locale == "ur") ? "rtl" : "ltr";
+
+    return {
+      __proto__: null,
+
+      "@@ui_locale": [ui_locale, []],
+      "@@bidi_dir":  [bidi_dir,  []]
+    };

[Wladimir Palant, 2014/12/09 18:59:09]

Nit: Please consider using Object.create(null) instead of {__proto__:null}, the
latter being non-standard.

[Sebastian Noack, 2014/12/09 19:30:16]

I haven't seen through your policy for unrelated changes yet. ;)

Done.

[Wladimir Palant, 2014/12/09 19:55:37]

The policy is very simple - fix the code when you touch it, unless it will
complicate the review significantly. :)

+  };
+
   var locales = getLocaleCandidates();
-  var catalog = {__proto__: null, "@@ui_locale": [locales[0], []]};
+  var catalog = initCatalog(locales[0]);
 
   var replacePlaceholder = function(text, placeholder, content)
   {
     return text.split("$" + placeholder + "$").join(content || "");
   };
 
   var parseMessage = function(rawMessage)
   {
     var text = rawMessage.message;
     var placeholders = [];
@@ skipping 64 matching lines @@
   };
 
 
   /* Utils */
 
   ext.getURL = function(path)
   {
     return safari.extension.baseURI + path;
   };
 })();