Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 5410618009976832: issue #690 - don't consider special subscriptions when complaining about high subscription count (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by saroyanm
Modified:
5 years, 7 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/690

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/content/ui/sendReport.js View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7
saroyanm
Wladimir can you please have a look when you have time. Looks to be a ...
5 years, 7 months ago (2014-07-26 19:52:06 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js#newcode882 chrome/content/ui/sendReport.js:882: numGeneralSubscriptions: 0, I see no point renaming this property, ...
5 years, 7 months ago (2014-07-28 09:17:18 UTC) #2
saroyanm
On 2014/07/28 09:17:18, Wladimir Palant wrote: > http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js > File chrome/content/ui/sendReport.js (right): > > http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js#newcode882 ...
5 years, 7 months ago (2014-07-28 09:49:10 UTC) #3
saroyanm
updated http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): http://codereview.adblockplus.org/5410618009976832/diff/5639274879778816/chrome/content/ui/sendReport.js#newcode882 chrome/content/ui/sendReport.js:882: numGeneralSubscriptions: 0, On 2014/07/28 09:17:18, Wladimir Palant wrote: ...
5 years, 7 months ago (2014-07-28 09:49:20 UTC) #4
Wladimir Palant
A few style issues below but seems fine otherwise. http://codereview.adblockplus.org/5410618009976832/diff/5657382461898752/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): http://codereview.adblockplus.org/5410618009976832/diff/5657382461898752/chrome/content/ui/sendReport.js#newcode755 chrome/content/ui/sendReport.js:755: ...
5 years, 7 months ago (2014-07-30 05:44:35 UTC) #5
saroyanm
Updated. http://codereview.adblockplus.org/5410618009976832/diff/5657382461898752/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): http://codereview.adblockplus.org/5410618009976832/diff/5657382461898752/chrome/content/ui/sendReport.js#newcode755 chrome/content/ui/sendReport.js:755: let subscriptions = FilterStorage.subscriptions.filter(subscriptionUpdateDataSource.subscriptionFilter); On 2014/07/30 05:44:35, Wladimir ...
5 years, 7 months ago (2014-07-30 06:11:58 UTC) #6
Wladimir Palant
5 years, 7 months ago (2014-07-30 09:43:55 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5