Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 5417063522762752: Issue 427 - Desugar arrow functions to normal or bound functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by tschuster
Modified:
5 years, 6 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Correctly deciding if the bind call is necessary is kind of hard, so I decided for some kind of best effort approach.

Patch Set 1 #

Total comments: 2

Patch Set 2 : I just decided to ignore eval and Function for now, I can open a new bug if we really want to ban t… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -20 lines) Patch
M autotest/abprewrite_source.js View 1 2 chunks +7 lines, -2 lines 0 comments Download
M autotest/test_abprewrite.js.expected View 1 1 chunk +19 lines, -0 lines 0 comments Download
M autotest/test_abprewrite_module.js.expected View 1 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/abprewrite.js View 1 2 chunks +43 lines, -18 lines 0 comments Download
M scripts/astDecompile.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
tschuster
5 years, 7 months ago (2014-05-10 12:46:28 UTC) #1
tschuster
On 2014/05/10 12:46:28, tschuster wrote: r?
5 years, 7 months ago (2014-05-13 18:07:37 UTC) #2
Wladimir Palant
Please make sure that (foo) => 1, (foo) => {return 1;} and (foo) => {return ...
5 years, 6 months ago (2014-05-15 06:53:44 UTC) #3
tschuster
I just decided to ignore eval and Function for now, I can open a new ...
5 years, 6 months ago (2014-05-18 10:55:23 UTC) #4
tschuster
r?
5 years, 6 months ago (2014-05-24 11:10:10 UTC) #5
Wladimir Palant
5 years, 6 months ago (2014-05-25 08:23:11 UTC) #6
LGTM, I somehow missed the update here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5