Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: iconAnimation.js

Issue 5426447338438656: Fix icon animation (Closed)
Patch Set: Created Feb. 27, 2014, 2:38 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« background.js ('K') | « background.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 iconAnimation = { 18 iconAnimation = {
19 _icons: new TabMap(), 19 _icons: new TabMap(),
20 _animatedTabs: new TabMap(), 20 _animatedTabs: new TabMap(),
21 step: 0, 21 _step: 0,
Sebastian Noack 2014/02/27 14:41:47 This stupid typo was the main reason icon animatio
22 22
23 update: function(severity) 23 update: function(severity)
24 { 24 {
25 if (severity == this._severity) 25 if (severity == this._severity)
26 return; 26 return;
27 27
28 if (!this._severity) 28 if (!this._severity)
29 this._start(); 29 this._start();
30 30
31 this._severity = severity; 31 this._severity = severity;
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 125
126 if (this._step < 10) 126 if (this._step < 10)
127 suffix += "-" + this._step; 127 suffix += "-" + this._step;
128 128
129 path = path.replace(/(?=\..+$)/, suffix); 129 path = path.replace(/(?=\..+$)/, suffix);
130 } 130 }
131 131
132 tab.browserAction.setIcon(path); 132 tab.browserAction.setIcon(path);
133 } 133 }
134 }; 134 };
OLDNEW
« background.js ('K') | « background.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld