background.js - Issue 5426447338438656: Fix icon animation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5426447338438656: Fix icon animation (Closed)

Patch Set: Created Feb. 27, 2014, 4:21 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -103,8 +103,7 @@

// Adds or removes browser action icon according to options.

function refreshIconAndContextMenu(tab)

{

- if(!/^https?:/.test(tab.url))

- return;

+ var excluded = !/^https?:/.test(tab.url) || isWhitelisted(tab.url);

var iconFilename;

if (require("info").platform == "safari")

@@ -113,10 +112,7 @@

// aren't per tab in Safari.

iconFilename = "icons/abp-16.png"

else

- {

- var excluded = isWhitelisted(tab.url);

iconFilename = excluded ? "icons/abp-19-whitelisted.png" : "icons/abp-19.png";

- }

tab.browserAction.setIcon(iconFilename);

iconAnimation.registerTab(tab, iconFilename);

« no previous file with comments | « no previous file | iconAnimation.js » ('j') | no next file with comments »