Issue 527 - Only process notification requests sent by our own extensions

sitescripts/stats/bin/logprocessor.py

Index: sitescripts/stats/bin/logprocessor.py
===================================================================
--- a/sitescripts/stats/bin/logprocessor.py
+++ b/sitescripts/stats/bin/logprocessor.py
@@ -397,6 +397,9 @@
     # Subscription downloads, libadblockplus update checks and notification
     # checks are performed by the downloader
     parse_downloader_query(info)
+
+    if filename == "notification.json" and info["addonName"] not in ("adblockplus", "adblockpluschrome", "adblockplusopera", "adblockplussafari"):

[Felix Dahlke, 2014/05/22 07:35:21]

I think we should filter this for all downloads really, objections Wladimir?

Also, not a fan of hard coding the addon names. How about anything that starts
with "adblockplus"?

[Wladimir Palant, 2014/05/22 07:44:05]

a) We really need to do this for all downloads, otherwise we will have a
distorted picture.
b) We don't want to filter unknown extensions in general. We want to know how
many users are on outdated Adblock Plus versions (not sending addonName
parameter) and the forks. We merely shouldn't count them for the
previousDownload field.
c) fhd is right, this approach won't scale. What about adblockplusandroid or
adblockplusie? .startswith("adblockplus") feels hacky but it seems to be the
better approach here.

[Sebastian Noack, 2014/05/22 08:40:39]

Done.

+      return None
   elif ext == ".tpl":
     # MSIE TPL download, no additional data here
     pass