Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1357)

Issue 5459448122310656: Add rietveld to infrastructure (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by christian
Modified:
5 years, 5 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Add rietveld to infrastructure

Patch Set 1 #

Total comments: 39

Patch Set 2 : Apply Changes #

Total comments: 6

Patch Set 3 : Add Changes #

Patch Set 4 : The two comments #

Total comments: 2

Patch Set 5 : Remove small dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -1 line) Patch
M Vagrantfile View 1 1 chunk +1 line, -0 lines 0 comments Download
A manifests/codereviewserver.pp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M manifests/monitoringserver.pp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M manifests/nodes.pp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M manifests/vagrant.pp View 1 1 chunk +1 line, -0 lines 0 comments Download
A modules/private-stub/manifests/rietveld.pp View 1 1 chunk +4 lines, -0 lines 0 comments Download
A modules/rietveld/files/Makefile View 1 chunk +46 lines, -0 lines 0 comments Download
A modules/rietveld/files/rietveld.conf View 1 chunk +14 lines, -0 lines 0 comments Download
A modules/rietveld/manifests/init.pp View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download
A modules/rietveld/templates/settings.py.erb View 1 1 chunk +107 lines, -0 lines 0 comments Download
A modules/rietveld/templates/site.erb View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10
christian
5 years, 5 months ago (2014-02-07 08:47:09 UTC) #1
Felix Dahlke
Looks good in general, tons of nits and some comments below :) http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/Vagrantfile File Vagrantfile ...
5 years, 5 months ago (2014-02-07 15:27:36 UTC) #2
christian
Apply Changes http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/Vagrantfile File Vagrantfile (right): http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/Vagrantfile#newcode54 Vagrantfile:54: define_standard_vm config, 'codereview', '10.8.0.132' On 2014/02/07 15:27:36, ...
5 years, 5 months ago (2014-02-07 17:17:21 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/files/settings.py File modules/rietveld/files/settings.py (right): http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/files/settings.py#newcode16 modules/rietveld/files/settings.py:16: DATABASE_ENGINE = 'sqlite3' # 'postgresql_psycopg2', 'postgresql', 'mysql', 'sqlite3' or ...
5 years, 5 months ago (2014-02-07 20:09:44 UTC) #4
christian
I add the Changes and add a trello board in the Doing section, you can ...
5 years, 5 months ago (2014-02-10 09:05:56 UTC) #5
Felix Dahlke
Looks to me like you missed two comments: http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/manifests/init.pp#newcode61 http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/manifests/init.pp#newcode65
5 years, 5 months ago (2014-02-12 11:45:36 UTC) #6
christian
Sorry, totally overlooked this. http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/manifests/init.pp File modules/rietveld/manifests/init.pp (right): http://codereview.adblockplus.org/5459448122310656/diff/5629499534213120/modules/rietveld/manifests/init.pp#newcode61 modules/rietveld/manifests/init.pp:61: #work around puppets limitation towards ...
5 years, 5 months ago (2014-02-12 14:14:26 UTC) #7
Felix Dahlke
http://codereview.adblockplus.org/5459448122310656/diff/5738600293466112/modules/rietveld/manifests/init.pp File modules/rietveld/manifests/init.pp (right): http://codereview.adblockplus.org/5459448122310656/diff/5738600293466112/modules/rietveld/manifests/init.pp#newcode72 modules/rietveld/manifests/init.pp:72: require => [Package['gunicorn'], File['/etc/init.d/rietveld'], Exec['install_rietveld']] Now the Exec['install_rietveld'] here ...
5 years, 5 months ago (2014-02-12 16:40:15 UTC) #8
christian
Done (Hopefully) http://codereview.adblockplus.org/5459448122310656/diff/5738600293466112/modules/rietveld/manifests/init.pp File modules/rietveld/manifests/init.pp (right): http://codereview.adblockplus.org/5459448122310656/diff/5738600293466112/modules/rietveld/manifests/init.pp#newcode72 modules/rietveld/manifests/init.pp:72: require => [Package['gunicorn'], File['/etc/init.d/rietveld'], Exec['install_rietveld']] On 2014/02/12 ...
5 years, 5 months ago (2014-02-12 16:45:31 UTC) #9
Felix Dahlke
5 years, 5 months ago (2014-02-12 17:02:29 UTC) #10
LGTM! :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5