Issue 1434 - Removed remaining non-standard JavaScript code from buildtools

lib/hooks.js

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 function hook(obj, name, func, cleanup)
 {
   let orig = obj[name];
-  let origGet = obj.__lookupGetter__(name);
-  let origSet = obj.__lookupSetter__(name);
+  let origDesc = Object.getOwnPropertyDescriptor(obj, name);
   let dumbOverrideAttempt = false;
 
   let newFunc = function()
   {
     let params = arguments;
     try
     {
       let result = func.apply(this, params);
       if (typeof result == "object")
         params = result;
@@ skipping 15 matching lines @@
   };
   newFunc.toString = function()
   {
     dumbOverrideAttempt = true;
     return orig.toString();
   };
   newFunc.toSource = function()
   {
     dumbOverrideAttempt = true;
     return orig.toSource();
-  }
+  };
 
-  obj.__defineGetter__(name, function()
-  {
-    dumbOverrideAttempt = false;
-    return newFunc;
-  });
-
-  obj.__defineSetter__(name, function(value)
-  {
-    if (dumbOverrideAttempt)
+  Object.defineProperty(obj, name, {
+    get: function()
     {
-      orig = value;
-    }
-    else
+      dumbOverrideAttempt = false;
+      return newFunc;
+    },
+    set: function(value)
     {
-      delete obj[name];
-      obj[name] = value;
-    }
+      if (dumbOverrideAttempt)
+      {
+        orig = value;
+      }
+      else
+      {
+        delete obj[name];
+        obj[name] = value;

[tschuster, 2015/06/17 11:01:55]

I would almost use Object.defineProperty here, but it's of course a bit more of
a mouthful.

Object.defineProperty(obj, name, {value: value, configurable: true, writable:
true, enumerable: true})

+      }
+    },
+    enumerable: true,
+    configurable: true
   });
 
   return function()
   {
-    delete obj[name];
-    obj[name] = orig;
-    if (origGet)
-    {
-      obj.__defineGetter__(name, origGet);
-    }
-    if (origSet)
-    {
-      obj.__defineSetter__(name, origSet);
-    }
+    Object.defineProperty(obj, name, origDesc);
   };
 }
 exports.hook = hook;