Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: notification.js

Issue 5464830253203456: Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction (Closed)
Patch Set: Created Feb. 22, 2014, 10:45 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« ext/common.js ('K') | « metadata.safari ('k') | popup.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 messageElement.addEventListener("click", function(event) 79 messageElement.addEventListener("click", function(event)
80 { 80 {
81 var link = event.target; 81 var link = event.target;
82 while (link && link !== messageElement && link.localName !== "a") 82 while (link && link !== messageElement && link.localName !== "a")
83 link = link.parentNode; 83 link = link.parentNode;
84 if (!link) 84 if (!link)
85 return; 85 return;
86 event.preventDefault(); 86 event.preventDefault();
87 event.stopPropagation(); 87 event.stopPropagation();
88 ext.windows.getLastFocused(function(win) { win.openTab(link.href); }); 88 » ext.pages.open(link.href);
Wladimir Palant 2014/04/04 14:00:35 Please use spaces for indentation.
Sebastian Noack 2014/04/07 13:15:25 Done.
89 }); 89 });
90 90
91 var notificationElement = document.getElementById("notification"); 91 var notificationElement = document.getElementById("notification");
92 notificationElement.className = notification.severity; 92 notificationElement.className = notification.severity;
93 notificationElement.style.display = "block"; 93 notificationElement.style.display = "block";
94 }); 94 });
OLDNEW
« ext/common.js ('K') | « metadata.safari ('k') | popup.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld