chrome/ext/popup.js - Issue 5464830253203456: Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/popup.js

Issue 5464830253203456: Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction (Closed)

Patch Set: Rebased and addressed comments Created April 7, 2014, 1:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 (function()	1 window.ext = {

2 {	2 __proto__: chrome.extension.getBackgroundPage().ext,

3 var backgroundPage = chrome.extension.getBackgroundPage();	3

4 window.ext = {	4 closePopup: function()

5 __proto__: backgroundPage.ext,	5 {

6 closePopup: function()	6 window.close();

7 {	7 }

8 window.close();	8 };

9 }

10 };

11 window.TabMap = backgroundPage.TabMap;

12 })();

OLD	NEW

« no previous file with comments | « chrome/ext/content.js ('k') | ext/background.js » ('j') | no next file with comments »