Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction

iconAnimation.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
- * Copyright (C) 2006-2013 Eyeo GmbH
+ * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 iconAnimation = {
   _icons: new ext.PageMap(),
   _animatedPages: new ext.PageMap(),
-  step: 0,
+  _step: 0,
 
-  update: function(severity)
+  update: function(type)
   {
-    if (severity == this._severity)
+    if (type == this._type)
        return;
 
-    if (!this._severity)
+    if (!this._type)
       this._start();
 
-    this._severity = severity;
+    this._type = type;
   },
   stop: function()
   {
     clearInterval(this._interval);
 
     delete this._interval;
-    delete this._severity;
+    delete this._type;
 
     this._animatedPages.clear();
   },
   registerPage: function(page, icon)
   {
     this._icons.set(page, icon);
 
     if (this._animatedPages.has(page))
       this._updateIcon(page);
   },
   _start: function()
   {
     this._interval = setInterval(function()
     {
-      ext.pages.query({active: true, visibleWindow: true}, function(pages)
+      ext.pages.query({active: true}, function(pages)
       {
         if (pages.length == 0)
           return;
 
         for (var i = 0; i < pages.length; i++)
           this._animatedPages.set(pages[i], null);
 
         var interval = setInterval(function()
         {
           this._step++;
@@ skipping 23 matching lines @@
   },
   _updateIcon: function(page)
   {
     var path = this._icons.get(page);
 
     if (!path)
       return;
 
     if (this._step > 0)
     {
-      var suffix = "-notification-" + this._severity;
+      var suffix = "-notification-" + this._type;
 
       if (this._step < 10)
         suffix += "-" + this._step;
 
       path = path.replace(/(?=\..+$)/, suffix);
     }
 
     page.browserAction.setIcon(path);
   }
 };