Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.common

Issue 5464830253203456: Refactored the abstraction layer to address prerendered pages on Safari caused by leaky abstraction (Closed)
Left Patch Set: Created Feb. 22, 2014, 10:45 a.m.
Right Patch Set: Addressed comments Created April 11, 2014, 2:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « metadata.chrome ('k') | metadata.safari » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [general] 1 [general]
2 version = 1.7.4 2 version = 1.7.4
3 backgroundScripts = ext/common.js 3 backgroundScripts = ext/common.js
4 ext/background.js 4 ext/background.js
5 lib/compat.js 5 lib/compat.js
6 lib/info.js 6 lib/info.js
7 lib/io.js 7 lib/io.js
8 lib/adblockplus.js 8 lib/adblockplus.js
9 lib/punycode.js 9 lib/punycode.js
10 lib/publicSuffixList.js 10 lib/publicSuffixList.js
11 lib/basedomain.js 11 lib/basedomain.js
12 lib/sha1.js 12 lib/sha1.js
13 lib/jsbn.js 13 lib/jsbn.js
14 lib/rsa.js 14 lib/rsa.js
15 webrequest.js 15 webrequest.js
16 popupBlocker.js 16 popupBlocker.js
17 iconAnimation.js 17 iconAnimation.js
18 background.js 18 background.js
19 permissions = http://*/* https://*/* 19 permissions = http://*/* https://*/*
20 20
21 [contentScripts] 21 [contentScripts]
22 document_start = ext/common.js ext/content.js include.preload.js 22 document_start = ext/common.js ext/content.js include.preload.js
23 document_end = include.postload.js 23 document_end = include.postload.js
24 24
25 [mapping] 25 [mapping]
26 ext/content.js = chrome/ext/content.js 26 ext/content.js = chrome/ext/content.js
27 ext/popup.js = chrome/ext/popup.js 27 ext/popup.js = chrome/ext/popup.js
28 notification.html = chrome/notification.html
28 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml 29 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml
29 firstRun.html = adblockplus/chrome/content/ui/firstRun.html 30 firstRun.html = adblockplus/chrome/content/ui/firstRun.html
30 firstRun.js = adblockplus/chrome/content/ui/firstRun.js 31 firstRun.js = adblockplus/chrome/content/ui/firstRun.js
31 i18n.js = adblockplus/chrome/content/ui/i18n.js 32 i18n.js = adblockplus/chrome/content/ui/i18n.js
32 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css 33 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css
33 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png 34 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png
34 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif 35 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif
35 skin/background.png = adblockplus/chrome/skin/background.png 36 skin/background.png = adblockplus/chrome/skin/background.png
36 skin/background-main.png = adblockplus/chrome/skin/background-main.png 37 skin/background-main.png = adblockplus/chrome/skin/background-main.png
37 skin/background-share.png = adblockplus/chrome/skin/background-share.png 38 skin/background-share.png = adblockplus/chrome/skin/background-share.png
(...skipping 21 matching lines...) Expand all
59 adblockplus/lib/downloader.js 60 adblockplus/lib/downloader.js
60 adblockplus/lib/filterNotifier.js 61 adblockplus/lib/filterNotifier.js
61 adblockplus/lib/filterClasses.js 62 adblockplus/lib/filterClasses.js
62 adblockplus/lib/subscriptionClasses.js 63 adblockplus/lib/subscriptionClasses.js
63 adblockplus/lib/filterStorage.js 64 adblockplus/lib/filterStorage.js
64 adblockplus/lib/elemHide.js 65 adblockplus/lib/elemHide.js
65 adblockplus/lib/matcher.js 66 adblockplus/lib/matcher.js
66 adblockplus/lib/filterListener.js 67 adblockplus/lib/filterListener.js
67 adblockplus/lib/synchronizer.js 68 adblockplus/lib/synchronizer.js
68 adblockplus/lib/notification.js 69 adblockplus/lib/notification.js
70 adblockplus/lib/antiadblockInit.js
69 lib/stats.js 71 lib/stats.js
70 lib/whitelisting.js 72 lib/whitelisting.js
71 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/ 73 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/
72 ext/common.js = ext/common.js chrome/ext/common.js 74 ext/common.js = ext/common.js chrome/ext/common.js
73 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand 75 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand
74 76
75 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js 77 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js
76 adblockplustests/chrome/content/tests/filterClasses.js 78 adblockplustests/chrome/content/tests/filterClasses.js
77 adblockplustests/chrome/content/tests/filterNotifier.js 79 adblockplustests/chrome/content/tests/filterNotifier.js
78 adblockplustests/chrome/content/tests/filterStorage.js 80 adblockplustests/chrome/content/tests/filterStorage.js
79 adblockplustests/chrome/content/tests/matcher.js 81 adblockplustests/chrome/content/tests/matcher.js
80 adblockplustests/chrome/content/tests/prefs.js 82 adblockplustests/chrome/content/tests/prefs.js
81 adblockplustests/chrome/content/tests/regexpFilters_matching.js 83 adblockplustests/chrome/content/tests/regexpFilters_matching.js
82 adblockplustests/chrome/content/tests/subscriptionClasses.js 84 adblockplustests/chrome/content/tests/subscriptionClasses.js
83 --arg source_repo=https://hg.adblockplus.org/adblockplustests/ 85 --arg source_repo=https://hg.adblockplus.org/adblockplustests/
84 86
85 [import_locales] 87 [import_locales]
86 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location 88 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location
87 remove_subscription_warning 89 remove_subscription_warning
90 notification_antiadblock_title
91 notification_antiadblock_message
88 adblockplus/chrome/locale/*/overlay.dtd = hideplaceholders.label 92 adblockplus/chrome/locale/*/overlay.dtd = hideplaceholders.label
93 notification.button.yes
94 notification.button.no
95 notification.button.close
89 adblockplus/chrome/locale/*/filters.dtd = subscription.lastDownload.inProgress 96 adblockplus/chrome/locale/*/filters.dtd = subscription.lastDownload.inProgress
90 subscription.lastDownload.invalidURL 97 subscription.lastDownload.invalidURL
91 subscription.lastDownload.connectionError 98 subscription.lastDownload.connectionError
92 subscription.lastDownload.invalidData 99 subscription.lastDownload.invalidData
93 subscription.lastDownload.checksumMismatch 100 subscription.lastDownload.checksumMismatch
94 subscription.enabled.label 101 subscription.enabled.label
95 subscription.delete.label 102 subscription.delete.label
96 addSubscription.label 103 addSubscription.label
97 addSubscriptionAdd.label 104 addSubscriptionAdd.label
98 addSubscriptionOther.label 105 addSubscriptionOther.label
99 acceptableAds2.label 106 acceptableAds2.label
100 viewList.label 107 viewList.label
101 readMore.label 108 readMore.label
102 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label 109 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label
103 title.label 110 title.label
104 adblockplus/chrome/locale/*/meta.properties = =name 111 adblockplus/chrome/locale/*/meta.properties = =name
105 adblockplus/chrome/locale/*/firstRun.properties = =* 112 adblockplus/chrome/locale/*/firstRun.properties = =*
LEFTRIGHT

Powered by Google App Engine
This is Rietveld