src/plugin/PluginUtil.h - Issue 5469643829411840: Issue 1795 - Add helper std::wstring GetLocationUrl(IWebBrowser2& browser)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/plugin/PluginUtil.h

Issue 5469643829411840: Issue 1795 - Add helper std::wstring GetLocationUrl(IWebBrowser2& browser) (Closed)

Patch Set: Created Jan. 13, 2015, 3:22 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #pragma once	1 #pragma once

2 #include <string>	2 #include <string>

3	3

4 std::wstring HtmlFolderPath();	4 std::wstring HtmlFolderPath();

5 std::wstring UserSettingsFileUrl();	5 std::wstring UserSettingsFileUrl();

6 std::wstring FirstRunPageFileUrl();	6 std::wstring FirstRunPageFileUrl();

7 std::wstring FileUrl(const std::wstring& url);	7 std::wstring FileUrl(const std::wstring& url);

	8 std::wstring GetLocationUrl(IWebBrowser2& browser);
	Eric 2015/01/13 17:04:20 I had a version of this function in the string con I had a version of this function in the string conversion I did last summer (the one that no one liked). Instead of a collection of loose functions all taking IWebBrowser2 arguments, this and analogous functions were methods of a wrapper class. Since you're already using a reference (assuming null checking is elsewhere), there's no reason not to start off by making this a wrapper class. sergei 2015/01/29 12:42:11 Should I create the class for it? Show quoted text On 2015/01/13 17:04:20, Eric wrote: > I had a version of this function in the string conversion I did last summer (the > one that no one liked). Instead of a collection of loose functions all taking > IWebBrowser2 arguments, this and analogous functions were methods of a wrapper > class. Since you're already using a reference (assuming null checking is > elsewhere), there's no reason not to start off by making this a wrapper class. Should I create the class for it? Eric 2015/02/02 19:07:54 The next time you write a function with an argumen Show quoted text On 2015/01/29 12:42:11, sergei wrote: > Should I create the class for it? The next time you write a function with an argument of type 'IBrowser2&', that's the time to create a class for it and use methods. Not so much need when there's only one loose function about.
	9

OLD	NEW

« no previous file with comments | « no previous file | src/plugin/PluginUtil.cpp » ('j') | src/plugin/PluginUtil.cpp » ('J')