src/plugin/PluginUtil.h - Issue 5469643829411840: Issue 1795 - Add helper std::wstring GetLocationUrl(IWebBrowser2& browser)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginUtil.h

Issue 5469643829411840: Issue 1795 - Add helper std::wstring GetLocationUrl(IWebBrowser2& browser) (Closed)

Left Patch Set: Created Jan. 13, 2015, 3:22 p.m.

Right Patch Set: get rid of variable in the function body Created Jan. 29, 2015, 12:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
	1 /*

	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

	3 * Copyright (C) 2006-2015 Eyeo GmbH

	4 *

	5 * Adblock Plus is free software: you can redistribute it and/or modify

	6 * it under the terms of the GNU General Public License version 3 as

	7 * published by the Free Software Foundation.

	8 *

	9 * Adblock Plus is distributed in the hope that it will be useful,

	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 * GNU General Public License for more details.

	13 *

	14 * You should have received a copy of the GNU General Public License

	15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	16 */

	17

1 #pragma once	18 #pragma once

2 #include <string>	19 #include <string>

3	20

4 std::wstring HtmlFolderPath();	21 std::wstring HtmlFolderPath();

5 std::wstring UserSettingsFileUrl();	22 std::wstring UserSettingsFileUrl();

6 std::wstring FirstRunPageFileUrl();	23 std::wstring FirstRunPageFileUrl();

7 std::wstring FileUrl(const std::wstring& url);	24 std::wstring FileUrl(const std::wstring& url);

8 std::wstring GetLocationUrl(IWebBrowser2& browser);	25 std::wstring GetLocationUrl(IWebBrowser2& browser);
Eric 2015/01/13 17:04:20 I had a version of this function in the string con I had a version of this function in the string conversion I did last summer (the one that no one liked). Instead of a collection of loose functions all taking IWebBrowser2 arguments, this and analogous functions were methods of a wrapper class. Since you're already using a reference (assuming null checking is elsewhere), there's no reason not to start off by making this a wrapper class. sergei 2015/01/29 12:42:11 Should I create the class for it? Show quoted text On 2015/01/13 17:04:20, Eric wrote: > I had a version of this function in the string conversion I did last summer (the > one that no one liked). Instead of a collection of loose functions all taking > IWebBrowser2 arguments, this and analogous functions were methods of a wrapper > class. Since you're already using a reference (assuming null checking is > elsewhere), there's no reason not to start off by making this a wrapper class. Should I create the class for it? Eric 2015/02/02 19:07:54 The next time you write a function with an argumen Show quoted text On 2015/01/29 12:42:11, sergei wrote: > Should I create the class for it? The next time you write a function with an argument of type 'IBrowser2&', that's the time to create a class for it and use methods. Not so much need when there's only one loose function about.
9	26
	Oleksandr 2015/01/30 14:29:45 No new string in the end of file, please No new string in the end of file, please
LEFT	RIGHT