Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5507124440334336: Made the team size calculated dynamically, based on the list of team members, which is defined only… (Closed)

Created:
Dec. 11, 2013, 6:31 p.m. by Sebastian Noack
Modified:
Dec. 15, 2013, 10:45 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Made the team size calculated dynamically, based on the list of team members, which is defined only…

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adressed comments #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
A includes/globals.tmpl View 1 1 chunk +21 lines, -0 lines 0 comments Download
M includes/jobs/overview.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M includes/jobs/why.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M includes/press/company-info.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M includes/press/faq.md View 1 chunk +1 line, -1 line 0 comments Download
A includes/size-of-team.tmpl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A includes/size-of-team-plus-one.tmpl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pages/team.tmpl View 1 2 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
Dec. 11, 2013, 6:32 p.m. (2013-12-11 18:32:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md File includes/jobs/overview.md (right): http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md#newcode3 includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who manage ...
Dec. 11, 2013, 6:48 p.m. (2013-12-11 18:48:28 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md File includes/jobs/overview.md (right): http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md#newcode3 includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who manage ...
Dec. 11, 2013, 7:30 p.m. (2013-12-11 19:30:27 UTC) #3
Wladimir Palant
Mostly fine, the paths for {% include %} will have to be adjusted however once ...
Dec. 12, 2013, 7:29 a.m. (2013-12-12 07:29:28 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md File includes/jobs/overview.md (right): http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/includes/jobs/overview.md#newcode3 includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who manage ...
Dec. 12, 2013, 10:37 a.m. (2013-12-12 10:37:21 UTC) #5
Wladimir Palant
Dec. 13, 2013, 8:58 p.m. (2013-12-13 20:58:40 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld