Issue 1801 - Use URL objects to process URLs in the background page

lib/url.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 88 matching lines @@
 
   let host = getDecodedHostname(url);
   if (url.port)
     host += ":" + url.port;
   return protocol + "//" + host + url.pathname + url.search;
 }
 exports.stringifyURL = stringifyURL;
 
 function isDomain(hostname)
 {
-  // IPv4 address, also considering hexadecimal octets.
-  if (/^((0x[\da-f]+|\d+)(\.|$)){4}$/i.test(hostname))

[Wladimir Palant, 2015/02/11 13:45:45]

This won't accept "0x5bec7a38" - should be {1,4} I guess? Or maybe just keep the
number of octets arbitrary, for simplicity? Meaning:
/^((0x[\da-f]+|\d+)(\.|$))+$/i

[Sebastian Noack, 2015/02/11 17:07:06]

Even better; arbitrary and optional. So we also bail out if there is no
hostname, like for about:blank URLs.

+  // No hostname or IPv4 address, also considering hexadecimal octets.
+  if (/^((0x[\da-f]+|\d+)(\.|$))*$/i.test(hostname))
     return false;
 
   // IPv6 address. Since there can't be colons in domains, we can
   // just check whether there are any colons to exclude IPv6 addresses.
   return hostname.indexOf(":") == -1;
 }
 
 function getBaseDomain(hostname)
 {
   let bits = hostname.split(".");
@@ skipping 30 matching lines @@
 
   if (requestHost == documentHost)
     return false;
 
   if (!isDomain(requestHost) || !isDomain(documentHost))
     return true;
 
   return getBaseDomain(requestHost) != getBaseDomain(documentHost);
 }
 exports.isThirdParty = isThirdParty;