Implemented ext.contextMenus for Safari

include.postload.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 544 matching lines @@
           clickHide_mouseClick(lastRightClickEvent);
         }
         else
           console.log("clickhide-new-filter: URLs don't match. Couldn't find that element.", request.filter, url, lastRightClickEvent.target.src);
         break;
       case "clickhide-init":
         if (clickHideFiltersDialog)
         {
           sendResponse({filters: clickHide_filters});
 
-          clickHideFiltersDialog.style.width = (msg.width + 5) + "px";
-          clickHideFiltersDialog.style.height = (msg.height + 15) + "px";

[Thomas Greiner, 2014/01/07 12:13:11]

This was necessary because Safari is otherwise showing both scrollbars.

[Sebastian Noack, 2014/01/07 14:13:14]

This is a hack. The problem here is that the code sending "clickhide-init", is
executed on DOMContentLoaded, and therefore before the resources are loaded. And
when the resources (like the ABP logo) are loaded the height will change. So the
proper solution would be to use the "load" event instead.

[Thomas Greiner, 2014/01/07 15:01:39]

Sounds like you addressed that already?! In that case I could just remove this
change from this review.

[Sebastian Noack, 2014/01/07 15:42:28]

No I didn't. I just figured out what the problem is while reviewing your
changes. You have to replace |$(init);| with |window.addEventListener("load",
init);| in popup.js. Also the +5 hack above that already has been there before,
can be removed, then.

[Thomas Greiner, 2014/01/07 16:15:51]

I see your point but block.html is included as an iFrame and iFrames don't adapt
their size dynamically. We need to explicitly set its width and height.

[Sebastian Noack, 2014/01/07 16:28:34]

Yes, that is true. And that is why we send a message with the content dimensions
from block.js to include.postload.js where it adjusts the size of the frame.

I just say that you have to get the dimensions of the frame's content during the
"load" event instead of the  DOMContentLoaded event. And that then there is no
need to add any offset when setting the dimensions of the frame.

[Thomas Greiner, 2014/01/07 17:39:42]

Sorry, I got a bit confused when you were talking about popup.js there.

Done.

[Sebastian Noack, 2014/01/07 17:42:21]

Sorry, I meant block.js.

+          clickHideFiltersDialog.style.width = msg.width + "px";
+          clickHideFiltersDialog.style.height = msg.height + "px";
           clickHideFiltersDialog.style.visibility = "visible";
         }
         break;
       case "clickhide-move":
         if (clickHideFiltersDialog)
         {
           clickHideFiltersDialog.style.left = (parseInt(clickHideFiltersDialog.style.left, 10) + request.x) + "px";
           clickHideFiltersDialog.style.top = (parseInt(clickHideFiltersDialog.style.top, 10) + request.y) + "px";
         }
         break;
       case "clickhide-close":
         if (clickHideFiltersDialog)
         {
           // Explicitly get rid of currentElement
           if (msg.remove && currentElement && currentElement.parentNode)
             currentElement.parentNode.removeChild(currentElement);
 
           clickHide_deactivate();
         }
         break;
       default:
         sendResponse({});
         break;
     }
   });
-
-  // Safari does not pass the element which the context menu is refering to
-  // so we need to add it to the event's user info.
-  if ("safari" in window)
-  {
-    document.addEventListener("contextmenu", function(event)

[Sebastian Noack, 2014/01/07 14:13:14]

This should go in safari/ext/content.js

[Thomas Greiner, 2014/01/07 15:01:39]

Done.

-    {
-      var element = event.srcElement;
-      safari.self.tab.setContextMenuEventUserInfo(event, {
-        srcUrl: ("src" in element) ? element.src : null,
-        tagName: element.tagName
-      });
-    }, false);
-  }
-}
+}