Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: safari/content.js

Issue 5589897452716032: Implemented ext.contextMenus for Safari (Closed)
Left Patch Set: Corrected width and height of clickhide popup Created Jan. 7, 2014, 5:37 p.m.
Right Patch Set: Created Jan. 18, 2014, 10:29 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« safari/background.js ('K') | « safari/background.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 306
307 ext.onMessage = new MessageEventTarget(safari.self); 307 ext.onMessage = new MessageEventTarget(safari.self);
308 308
309 // Safari does not pass the element which the context menu is refering to 309 // Safari does not pass the element which the context menu is refering to
310 // so we need to add it to the event's user info. 310 // so we need to add it to the event's user info.
311 document.addEventListener("contextmenu", function(event) 311 document.addEventListener("contextmenu", function(event)
312 { 312 {
313 var element = event.srcElement; 313 var element = event.srcElement;
314 safari.self.tab.setContextMenuEventUserInfo(event, { 314 safari.self.tab.setContextMenuEventUserInfo(event, {
315 srcUrl: ("src" in element) ? element.src : null, 315 srcUrl: ("src" in element) ? element.src : null,
316 tagName: element.tagName 316 tagName: element.localName
Wladimir Palant 2014/01/17 15:36:55 Please use localName here.
Thomas Greiner 2014/01/18 10:32:05 Done.
317 }); 317 });
318 }, false); 318 }, false);
319 })(); 319 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld