Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 5598654983307264: Issue 1751 - Highlight elements by injecting an overlay (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Sebastian Noack
Modified:
4 years, 9 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1751 - Highlight elements by injecting an overlay

Patch Set 1 : #

Total comments: 11

Patch Set 2 : Rebased and addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -78 lines) Patch
M include.postload.js View 1 8 chunks +25 lines, -78 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
4 years, 9 months ago (2015-01-05 15:35:56 UTC) #1
kzar
http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js#newcode60 include.postload.js:60: element._unhighlight = function() Could this cause a memory leak ...
4 years, 9 months ago (2015-01-13 11:04:24 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js#newcode60 include.postload.js:60: element._unhighlight = function() On 2015/01/13 11:04:24, kzar wrote: > ...
4 years, 9 months ago (2015-01-13 13:03:52 UTC) #3
kzar
http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js#newcode263 include.postload.js:263: overlay.setAttribute('style', 'opacity:0.4; display:inline-box; position:absolute; overflow:hidden; box-sizing:border-box;'); On 2015/01/13 11:04:24, ...
4 years, 9 months ago (2015-01-13 13:26:33 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5598654983307264/diff/5717271485874176/include.postload.js#newcode263 include.postload.js:263: overlay.setAttribute('style', 'opacity:0.4; display:inline-box; position:absolute; overflow:hidden; box-sizing:border-box;'); On 2015/01/13 13:26:34, ...
4 years, 9 months ago (2015-01-13 13:36:10 UTC) #5
kzar
4 years, 9 months ago (2015-01-13 14:02:12 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5