Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/FilterEngine.h

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: rebase Created Aug. 3, 2015, 8:28 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 void RemoveFromList(); 72 void RemoveFromList();
73 73
74 bool operator==(const Filter& filter) const; 74 bool operator==(const Filter& filter) const;
75 75
76 /** 76 /**
77 * Creates a wrapper for an existing JavaScript filter object. 77 * Creates a wrapper for an existing JavaScript filter object.
78 * Normally you shouldn't call this directly, but use 78 * Normally you shouldn't call this directly, but use
79 * FilterEngine::GetFilter() instead. 79 * FilterEngine::GetFilter() instead.
80 * @param value JavaScript filter object. 80 * @param value JavaScript filter object.
81 */ 81 */
82 Filter(JsValuePtr value); 82 Filter(JsValue&& value);
83 }; 83 };
84 84
85 /** 85 /**
86 * Wrapper for a subscription object. 86 * Wrapper for a subscription object.
87 * There are no accessors for most 87 * There are no accessors for most
88 * [subscription properties](https://adblockplus.org/jsdoc/adblockplus/symbols /Subscription.html), 88 * [subscription properties](https://adblockplus.org/jsdoc/adblockplus/symbols /Subscription.html),
89 * use `GetProperty()` to retrieve them by name. 89 * use `GetProperty()` to retrieve them by name.
90 */ 90 */
91 class Subscription : public JsValue, 91 class Subscription : public JsValue,
92 public std::tr1::enable_shared_from_this<Subscription> 92 public std::tr1::enable_shared_from_this<Subscription>
(...skipping 28 matching lines...) Expand all
121 bool IsUpdating(); 121 bool IsUpdating();
122 122
123 bool operator==(const Subscription& subscription) const; 123 bool operator==(const Subscription& subscription) const;
124 124
125 /** 125 /**
126 * Creates a wrapper for an existing JavaScript subscription object. 126 * Creates a wrapper for an existing JavaScript subscription object.
127 * Normally you shouldn't call this directly, but use 127 * Normally you shouldn't call this directly, but use
128 * FilterEngine::GetSubscription() instead. 128 * FilterEngine::GetSubscription() instead.
129 * @param value JavaScript subscription object. 129 * @param value JavaScript subscription object.
130 */ 130 */
131 Subscription(JsValuePtr value); 131 Subscription(JsValue&& value);
132 }; 132 };
133 133
134 /** 134 /**
135 * Shared smart pointer to a `Filter` instance. 135 * Shared smart pointer to a `Filter` instance.
136 */ 136 */
137 typedef std::tr1::shared_ptr<Filter> FilterPtr; 137 typedef std::tr1::shared_ptr<Filter> FilterPtr;
138 138
139 /** 139 /**
140 * Shared smart pointer to a `Subscription` instance. 140 * Shared smart pointer to a `Subscription` instance.
141 */ 141 */
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params); 410 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
411 void UpdateCheckDone(const std::string& eventName, 411 void UpdateCheckDone(const std::string& eventName,
412 UpdateCheckDoneCallback callback, JsValueList& params); 412 UpdateCheckDoneCallback callback, JsValueList& params);
413 void FilterChanged(FilterChangeCallback callback, JsValueList& params); 413 void FilterChanged(FilterChangeCallback callback, JsValueList& params);
414 void ShowNotification(const ShowNotificationCallback& callback, 414 void ShowNotification(const ShowNotificationCallback& callback,
415 const JsValueList& params); 415 const JsValueList& params);
416 }; 416 };
417 } 417 }
418 418
419 #endif 419 #endif
OLDNEW
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld