Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/FilterEngine.h

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: rebase Created Nov. 13, 2015, 1:54 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 void RemoveFromList(); 70 void RemoveFromList();
71 71
72 bool operator==(const Filter& filter) const; 72 bool operator==(const Filter& filter) const;
73 73
74 /** 74 /**
75 * Creates a wrapper for an existing JavaScript filter object. 75 * Creates a wrapper for an existing JavaScript filter object.
76 * Normally you shouldn't call this directly, but use 76 * Normally you shouldn't call this directly, but use
77 * FilterEngine::GetFilter() instead. 77 * FilterEngine::GetFilter() instead.
78 * @param value JavaScript filter object. 78 * @param value JavaScript filter object.
79 */ 79 */
80 Filter(JsValuePtr value); 80 Filter(JsValue&& value);
81 }; 81 };
82 82
83 /** 83 /**
84 * Wrapper for a subscription object. 84 * Wrapper for a subscription object.
85 * There are no accessors for most 85 * There are no accessors for most
86 * [subscription properties](https://adblockplus.org/jsdoc/adblockplus/symbols /Subscription.html), 86 * [subscription properties](https://adblockplus.org/jsdoc/adblockplus/symbols /Subscription.html),
87 * use `GetProperty()` to retrieve them by name. 87 * use `GetProperty()` to retrieve them by name.
88 */ 88 */
89 class Subscription : public JsValue, 89 class Subscription : public JsValue,
90 public std::enable_shared_from_this<Subscription> 90 public std::enable_shared_from_this<Subscription>
(...skipping 28 matching lines...) Expand all
119 bool IsUpdating(); 119 bool IsUpdating();
120 120
121 bool operator==(const Subscription& subscription) const; 121 bool operator==(const Subscription& subscription) const;
122 122
123 /** 123 /**
124 * Creates a wrapper for an existing JavaScript subscription object. 124 * Creates a wrapper for an existing JavaScript subscription object.
125 * Normally you shouldn't call this directly, but use 125 * Normally you shouldn't call this directly, but use
126 * FilterEngine::GetSubscription() instead. 126 * FilterEngine::GetSubscription() instead.
127 * @param value JavaScript subscription object. 127 * @param value JavaScript subscription object.
128 */ 128 */
129 Subscription(JsValuePtr value); 129 Subscription(JsValue&& value);
130 }; 130 };
131 131
132 /** 132 /**
133 * Shared smart pointer to a `Filter` instance. 133 * Shared smart pointer to a `Filter` instance.
134 */ 134 */
135 typedef std::shared_ptr<Filter> FilterPtr; 135 typedef std::shared_ptr<Filter> FilterPtr;
136 136
137 /** 137 /**
138 * Shared smart pointer to a `Subscription` instance. 138 * Shared smart pointer to a `Subscription` instance.
139 */ 139 */
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params); 406 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
407 void UpdateCheckDone(const std::string& eventName, 407 void UpdateCheckDone(const std::string& eventName,
408 UpdateCheckDoneCallback callback, JsValueList& params); 408 UpdateCheckDoneCallback callback, JsValueList& params);
409 void FilterChanged(FilterChangeCallback callback, JsValueList& params); 409 void FilterChanged(FilterChangeCallback callback, JsValueList& params);
410 void ShowNotification(const ShowNotificationCallback& callback, 410 void ShowNotification(const ShowNotificationCallback& callback,
411 const JsValueList& params); 411 const JsValueList& params);
412 }; 412 };
413 } 413 }
414 414
415 #endif 415 #endif
OLDNEW
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld