Issue 1550 - Get rid of V8ValueHolder.h

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
     NotificationTypes::const_iterator notificationTypeIterator = std::find_if(
       notificationTypes.begin(), notificationTypes.end(), findBySecond);
     if (notificationTypeIterator == notificationTypes.end())
     {
       return NotificationType::NOTIFICATION_TYPE_INFORMATION;
     }
     return notificationTypeIterator->first;
   }
 }
 
-Notification::Notification(const JsValuePtr& jsValue)
-  : JsValue(jsValue)
+Notification::Notification(JsValue&& jsValue)
+  : JsValue(std::move(jsValue))
 {
 }
 
 NotificationType Notification::GetType() const
 {
   return type;
 }
 
 const std::string& Notification::GetTitle() const
 {
@@ skipping 22 matching lines @@
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
   JsValueList params;
   params.push_back(GetProperty("id"));
   jsEngine->Evaluate("API.markNotificationAsShown")->Call(params);
 }
 
-NotificationPtr Notification::JsValueToNotification(const JsValuePtr& jsValue)
+NotificationPtr Notification::JsValueToNotification(JsValue&& jsValue)
 {
-  if (!jsValue || !jsValue->IsObject())
+  if (!jsValue.IsObject())
   {
     return NotificationPtr();
   }
 
-  NotificationPtr notification(new Notification(jsValue));
+  NotificationPtr notification(new Notification(std::move(jsValue)));
   JsValuePtr jsType = notification->GetProperty("type");
   notification->type = StringToNotificationType(jsType ? jsType->AsString() : "");
 
   JsValueList params;
   params.push_back(notification);
   JsValuePtr func = notification->jsEngine->Evaluate("API.getNotificationTexts");
   JsValuePtr jsTexts = func->Call(params);
   JsValuePtr jsTitle = jsTexts->GetProperty("title");
   if (jsTitle->IsString())
   {
     notification->title = jsTitle->AsString();
   }
   JsValuePtr jsMessage = jsTexts->GetProperty("message");
   if (jsMessage->IsString())
   {
     notification->message = jsMessage->AsString();
   }
   return notification;
 }