Issue 1550 - Get rid of V8ValueHolder.h

include/AdblockPlus/JsValue.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 106 matching lines @@
 
     /**
      * Invokes the value as a function (see `IsFunction()`).
      * @param params Optional list of parameters.
      * @param thisPtr Optional `this` value.
      * @return Value returned by the function.
      */
     JsValuePtr Call(const JsValueList& params = JsValueList(),
         AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
 
+    /**
+     * Invokes the value as a function (see `IsFunction()`) with single
+     * parameter.
+     * @param arg A single required parameter.
+     * @return Value returned by the function.
+     */
+    JsValuePtr Call(const JsValue& arg) const;
+
     v8::Local<v8::Value> UnwrapValue() const;
   protected:
     JsEnginePtr jsEngine;
   private:
     JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
     void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
     std::unique_ptr<v8::Persistent<v8::Value>> value;

[Oleksandr, 2016/01/22 12:11:14]

Aren't we leaking the value here? The idea behind V8ValueHolder was that we have
to dispose v8::Persistent handles ourselves, since they are not disposed in the
destructor (https://developers.google.com/v8/embed?hl=en). I don't see where
this value is disposed with this change.

   };
 }
 
 #endif