Issue 1550 - Get rid of V8ValueHolder.h

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 49 matching lines @@
 Notification::Notification(JsValue&& jsValue)
   : JsValue(std::move(jsValue))
 {
 }
 
 NotificationType Notification::GetType() const
 {
   return StringToNotificationType(GetProperty("type")->AsString());
 }
 
-NotificationTexts Notification::GetTexts()
+NotificationTexts Notification::GetTexts() const
 {
-  JsValueList params;
-  params.push_back(shared_from_this());
-  JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(params);
+  JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(*this);
   NotificationTexts notificationTexts;
   JsValuePtr jsTitle = jsTexts->GetProperty("title");
   if (jsTitle->IsString())
   {
     notificationTexts.title = jsTitle->AsString();
   }
   JsValuePtr jsMessage = jsTexts->GetProperty("message");
   if (jsMessage->IsString())
   {
     notificationTexts.message = jsMessage->AsString();
@@ skipping 13 matching lines @@
   for (JsValueList::const_iterator linkIterator = urlLinksList.begin();
     linkIterator != urlLinksList.end(); ++linkIterator)
   {
     retValue.push_back((*linkIterator)->AsString());
   }
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
-  JsValueList params;
-  params.push_back(GetProperty("id"));
-  jsEngine->Evaluate("API.markNotificationAsShown")->Call(params);
+  jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));
 }