Issue 1550 - Get rid of V8ValueHolder.h

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
 AdblockPlus::JsValue::JsValue(AdblockPlus::JsValue&& src)
     : jsEngine(src.jsEngine),
       value(std::move(src.value))
 {
 }
 
 AdblockPlus::JsValue::~JsValue()
 {
   if (value)
   {
     value->Dispose();

[Eric, 2016/01/26 18:37:40]

The previous code had "Dispose(isolate)". Was there a breaking API change in v8
that this present change set presupposes?

[sergei, 2016/01/27 10:21:14]

The implementation of Dispose(isolate) is the following one:

// TODO(dcarney): deprecate
V8_INLINE(void Dispose(Isolate* isolate)) { Dispose(); }

FYI: In a newer version of v8 the method Dispose will go away, there will be
Reset() which is called from the destructor ~UniquePersistent().

[Eric, 2016/02/08 19:50:07]

Clear as mud.

A version number would a much better answer. Was there a breaking API change? If
so, what was the version number where it first appeared?
What version number is that? Has it been released, or planned for the future?

     value.reset();
   }
 }
 
 bool AdblockPlus::JsValue::IsUndefined() const
 {
   const JsContext context(jsEngine);
   return UnwrapValue()->IsUndefined();
 }
 
@@ skipping 175 matching lines @@
   const v8::TryCatch tryCatch;
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, argv.size(),
       argv.size() ? &argv.front() : 0);
 
   if (tryCatch.HasCaught())
     throw JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValuePtr(new JsValue(jsEngine, result));
 }
+
+AdblockPlus::JsValuePtr AdblockPlus::JsValue::Call(const JsValue& arg) const
+{
+  const JsContext context(jsEngine);
+  JsValueList params;
+  params.push_back(JsValuePtr(new JsValue(arg.jsEngine, arg.UnwrapValue())));
+  return Call(params);
+}