Issue 1550 - Get rid of V8ValueHolder.h

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2015 Eyeo GmbH
+ * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 43 matching lines @@
   }
 }
 
 Notification::Notification(JsValue&& jsValue)
   : JsValue(std::move(jsValue))
 {
 }
 
 NotificationType Notification::GetType() const
 {
-  return type;
+  return StringToNotificationType(GetProperty("type")->AsString());
 }
 
-const std::string& Notification::GetTitle() const
+NotificationTexts Notification::GetTexts() const
 {
-  return title;
-}
-
-const std::string& Notification::GetMessageString() const
-{
-  return message;
+  JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(*this);
+  NotificationTexts notificationTexts;
+  JsValuePtr jsTitle = jsTexts->GetProperty("title");
+  if (jsTitle->IsString())
+  {
+    notificationTexts.title = jsTitle->AsString();
+  }
+  JsValuePtr jsMessage = jsTexts->GetProperty("message");
+  if (jsMessage->IsString())
+  {
+    notificationTexts.message = jsMessage->AsString();
+  }
+  return notificationTexts;
 }
 
 std::vector<std::string> Notification::GetLinks() const
 {
   std::vector<std::string> retValue;
   JsValuePtr jsLinks = GetProperty("links");
   if (!jsLinks->IsArray())
   {
     return retValue;
   }
   JsValueList urlLinksList = jsLinks->AsList();
   for (JsValueList::const_iterator linkIterator = urlLinksList.begin();
     linkIterator != urlLinksList.end(); ++linkIterator)
   {
     retValue.push_back((*linkIterator)->AsString());
   }
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
-  JsValueList params;
-  params.push_back(GetProperty("id"));
-  jsEngine->Evaluate("API.markNotificationAsShown")->Call(params);
-}
-
-NotificationPtr Notification::JsValueToNotification(JsValue&& jsValue)
-{
-  if (!jsValue.IsObject())
-  {
-    return NotificationPtr();
-  }
-
-  NotificationPtr notification(new Notification(std::move(jsValue)));
-  JsValuePtr jsType = notification->GetProperty("type");
-  notification->type = StringToNotificationType(jsType ? jsType->AsString() : "");
-
-  JsValueList params;
-  params.push_back(notification);
-  JsValuePtr func = notification->jsEngine->Evaluate("API.getNotificationTexts");
-  JsValuePtr jsTexts = func->Call(params);
-  JsValuePtr jsTitle = jsTexts->GetProperty("title");
-  if (jsTitle->IsString())
-  {
-    notification->title = jsTitle->AsString();
-  }
-  JsValuePtr jsMessage = jsTexts->GetProperty("message");
-  if (jsMessage->IsString())
-  {
-    notification->message = jsMessage->AsString();
-  }
-  return notification;
+  jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));
 }