Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: rebase Created Nov. 13, 2015, 1:54 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | include/AdblockPlus/JsValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
diff --git a/include/AdblockPlus/JsEngine.h b/include/AdblockPlus/JsEngine.h
index bdea44394cec6d5af498afeccf2b021e79979163..2893752f6738d6d585a0b75c65d67d759d513b92 100644
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -29,8 +29,6 @@
#include <AdblockPlus/JsValue.h>
#include <AdblockPlus/WebRequest.h>
-#include "V8ValueHolder.h"
-
namespace v8
{
class Arguments;
@@ -224,7 +222,7 @@ namespace AdblockPlus
WebRequestPtr webRequest;
LogSystemPtr logSystem;
v8::Isolate* isolate;
- V8ValueHolder<v8::Context> context;
+ std::unique_ptr<v8::Persistent<v8::Context>> context;
EventMap eventCallbacks;
JsValuePtr globalJsObject;
};
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | include/AdblockPlus/JsValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld