src/JsContext.cpp - Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/JsContext.cpp

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)

Patch Set: rebase Created Nov. 13, 2015, 1:54 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/JsContext.cpp

diff --git a/src/JsContext.cpp b/src/JsContext.cpp

index b93f978e517be65f2f27711d18c3b600fed14bd3..02858688b5d7be2c3bf3c313fef10a0671239d21 100644

--- a/src/JsContext.cpp

+++ b/src/JsContext.cpp

@@ -20,6 +20,6 @@

AdblockPlus::JsContext::JsContext(const JsEnginePtr jsEngine)

: locker(jsEngine->isolate), isolateScope(jsEngine->isolate),

handleScope(jsEngine->isolate),

- contextScope(v8::Local<v8::Context>::New(jsEngine->isolate, jsEngine->context))

+ contextScope(v8::Local<v8::Context>::New(jsEngine->isolate, *jsEngine->context))

{

}

« no previous file with comments | « src/FilterEngine.cpp ('k') | src/JsEngine.cpp » ('j') | no next file with comments »