Unified Diff: include/AdblockPlus/Notification.h
Issue 5598762307158016:
Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: fix JsValue destructor
Created Jan. 22, 2016, 1:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« include/AdblockPlus/JsValue.h ('k')
|
include/AdblockPlus/V8ValueHolder.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/Notification.h |
| diff --git a/include/AdblockPlus/Notification.h b/include/AdblockPlus/Notification.h |
| index bbfde9ef1ab014149bfa016698a78da984930a1c..2944a1384419c9f1fe48f1de64900efa18158692 100644 |
| --- a/include/AdblockPlus/Notification.h |
| +++ b/include/AdblockPlus/Notification.h |
| @@ -57,7 +57,7 @@ namespace AdblockPlus |
| * Constructor. |
| * @param jsValue `JsValuePtr` notification JavaScript object. |
|
Oleksandr
2016/01/22 14:02:37
The comment is leftover from JsValuePtr days
sergei
2016/01/22 14:34:54
Thanks, fixed
|
| */ |
| - explicit Notification(const JsValuePtr& jsValue); |
| + explicit Notification(JsValue&& jsValue); |
| public: |
| /** |
| * Retrieves the type of this notification. |
« no previous file with comments
|
« include/AdblockPlus/JsValue.h ('k')
|
include/AdblockPlus/V8ValueHolder.h » ('j')
|
no next file with comments »
