Unified Diff: src/JsEngine.cpp
Issue 5598762307158016:
Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: fix JsValue destructor
Created Jan. 22, 2016, 1:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« include/AdblockPlus/Notification.h ('K')
|
« src/JsContext.cpp ('k')
|
src/JsValue.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/JsEngine.cpp |
| diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp |
| index c8fbf413bd440bbcf82f8a85351837410ca8a4d0..73a786a9dddd2b2da8b5483d48bda35c613ecb25 100644 |
| --- a/src/JsEngine.cpp |
| +++ b/src/JsEngine.cpp |
| @@ -78,12 +78,11 @@ AdblockPlus::JsEnginePtr AdblockPlus::JsEngine::New(const AppInfo& appInfo) |
| const v8::Locker locker(result->isolate); |
| const v8::HandleScope handleScope; |
| - result->context.reset(result->isolate, v8::Context::New(result->isolate)); |
| - |
| + result->context.reset(new v8::Persistent<v8::Context>(result->isolate, |
| + v8::Context::New(result->isolate))); |
| v8::Local<v8::Object> globalContext = v8::Local<v8::Context>::New( |
| - result->isolate, result->context)->Global(); |
| + result->isolate, *result->context)->Global(); |
| result->globalJsObject = JsValuePtr(new JsValue(result, globalContext)); |
| - |
| AdblockPlus::GlobalJsObject::Setup(result, appInfo, result->globalJsObject); |
| return result; |
| } |
« include/AdblockPlus/Notification.h ('K')
|
« src/JsContext.cpp ('k')
|
src/JsValue.cpp » ('j')
|
no next file with comments »
