Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngine.cpp

Issue 5598762307158016: Issue 1550 - Get rid of V8ValueHolder.h (Closed)
Patch Set: Created Nov. 10, 2014, 9:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/JsContext.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsEngine.cpp
===================================================================
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -55,9 +55,10 @@
const v8::Locker locker(result->isolate);
const v8::HandleScope handleScope;
- result->context.reset(result->isolate, v8::Context::New(result->isolate));
+ result->context.reset(new v8::Persistent<v8::Context>(result->isolate,
+ v8::Context::New(result->isolate)));
v8::Local<v8::Object> globalContext = v8::Local<v8::Context>::New(
- result->isolate, result->context)->Global();
+ result->isolate, *result->context)->Global();
AdblockPlus::GlobalJsObject::Setup(result, appInfo,
JsValuePtr(new JsValue(result, globalContext)));
return result;
« no previous file with comments | « src/JsContext.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld