Issue 716 - Filter position cannot be changed using Ctrl-Up/Down keys

chrome/content/ui/filters-filteractions.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * Implementation of the various actions performed on the filters.
  * @class
  */
 var FilterActions =
 {
   /**
    * Initializes filter actions.
    */
   init: function()
   {
-    let me = this;
-    this.treeElement.parentNode.addEventListener("keypress", function(event)
-    {
-      me.keyPress(event);
-    }, true);
+    this.treeElement.parentNode.addEventListener("keydown", this.keyDown.bind(this), true);
     this.treeElement.view = FilterView;
 
     // Work around https://bugzilla.mozilla.org/show_bug.cgi?id=777832, don't
     // allow the tree to receive keypress/keydown events triggered by cursor
     // keys pressed in the editor, it will call preventDefault() on them.
     let propagationStopper = function(event)
     {
       if (event.keyCode >= event.DOM_VK_PAGE_UP && event.keyCode <= event.DOM_VK_DOWN)
         event.stopPropagation();
     };
@@ skipping 322 matching lines @@
       E("tooltip-additional").textContent = item.filter.reason;
     else if (item.filter instanceof RegExpFilter && defaultMatcher.isSlowFilter(item.filter))
       E("tooltip-additional").textContent = Utils.getString("filter_regexp_tooltip");
     else
       E("tooltip-additional").hidden = true;
   },
 
   /**
    * Called whenever a key is pressed on the list.
    */
-  keyPress: function(/**Event*/ event)
+  keyDown: function(/**Event*/ event)
   {
     if (event.target != E("filtersTree"))
       return;
 
     let modifiers = 0;
     if (event.altKey)
       modifiers |= SubscriptionActions._altMask;
     if (event.ctrlKey)
       modifiers |= SubscriptionActions._ctrlMask;
     if (event.metaKey)
@@ skipping 165 matching lines @@
       return;
 
     this.deleteItems(this.dragItems);
   }
 };
 
 window.addEventListener("load", function()
 {
   FilterActions.init();
 }, false);