Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5635941347622912: Resize popover on Safari only when the size of its content doesn't change anymore (Closed)

Created:
Feb. 26, 2014, 6:57 p.m. by Sebastian Noack
Modified:
Feb. 28, 2014, 8:13 a.m.
Visibility:
Public.

Description

We adjust the size of the popover on Safari when its content changes. But for example when removing a node just before adding another node to the DOM, the MutationObserver is triggered twice, and we are adjusting the size twice. And since Safari resizes the popover with a slow animation, this leads to strange effects. In order to fix that, I scheduled a timeout the first time the content changes. So the popover is only resized once when we are done with DOM manipulation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M safari/ext/popup.js View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Feb. 26, 2014, 7:09 p.m. (2014-02-26 19:09:02 UTC) #1
Felix Dahlke
Feb. 27, 2014, 9:42 p.m. (2014-02-27 21:42:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld