Issue 656 - Replace some __proto__ with Object.create

lib/sync.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 232 matching lines @@
   update: function(record)
   {
     if (record.id != filtersRecordID)
       return;
 
     this._log.trace("Merging in remote data");
 
     let data = record.cleartext.subscriptions;
 
     // First make sure we have the same subscriptions on both sides
-    let seenSubscription = {__proto__: null};
+    let seenSubscription = Object.create(null);
     for (let remoteSubscription of data)
     {
       seenSubscription[remoteSubscription.url] = true;
       if (remoteSubscription.url in FilterStorage.knownSubscriptions)
       {
         let subscription = FilterStorage.knownSubscriptions[remoteSubscription.url];
         if (!trackerInstance.didSubscriptionChange(remoteSubscription))
         {
           // Only change local subscription if there were no changes, otherwise dismiss remote changes
           subscription.disabled = remoteSubscription.disabled;
@@ skipping 21 matching lines @@
     for (let subscription of FilterStorage.subscriptions.slice())
     {
       if (!(subscription.url in seenSubscription) && subscription instanceof DownloadableSubscription && !trackerInstance.didSubscriptionChange(subscription))
       {
         // Subscription was removed remotely, remove it locally as well
         FilterStorage.removeSubscription(subscription);
       }
     }
 
     // Now sync the custom filters
-    let seenFilter = {__proto__: null};
+    let seenFilter = Object.create(null);
     for (let remoteSubscription of data)
     {
       if (!("filters" in remoteSubscription))
         continue;
 
       for (let remoteFilter of remoteSubscription.filters)
       {
         seenFilter[remoteFilter.text] = true;
 
         let filter = Filter.fromText(remoteFilter.text);
@@ skipping 144 matching lines @@
       case "filter.added":
       case "filter.removed":
       case "filter.disabled":
         this.addPrivateChange("filter " + item.text);
         break;
     }
   }
 };
 
 SyncServiceObserver.init();