Issue 1170 - [adblockplus.org Anwiki to CMS migration] Migrate content

filters/get_subscriptions.py

+# This file is part of the Adblock Plus website,
+# Copyright (C) 2006-2015 Eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+
+import codecs
+import os
+import tarfile
+import urllib
+
+from sitescripts.subscriptions.subscriptionParser import parse_file, calculate_supplemented
+
+def get_subscriptions(_):
+  result = {}
+  utf8_reader = codecs.getreader('utf8')
+  source = urllib.urlopen("https://hg.adblockplus.org/subscriptionlist/archive/default.tar.gz")
+  with tarfile.open(fileobj=source, mode="r|gz") as archive:
+    for fileinfo in archive:
+      if os.path.splitext(fileinfo.name)[1] != ".subscription":
+        continue
+
+      filedata = parse_file(fileinfo.name, utf8_reader(archive.extractfile(fileinfo)))
+      if filedata.unavailable:
+        continue
+
+      result[filedata.name] = filedata
+  source.close()

[Sebastian Noack, 2015/02/27 14:42:45]

Either:

  source = ...
  try:
    ...
  finally:
    source.close()

Or even better (if supported here):

  with ... as source:
    ...

[kzar, 2015/02/27 14:57:11]

Unfortunately "with ... as" wasn't supported, I did try that.
http://bugs.python.org/issue12955

Done.

+
+  calculate_supplemented(result)
+  return result.values()