devtools-panel.html - Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome

Side by Side Diff: devtools-panel.html

Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome (Closed)

Patch Set: Created Jan. 7, 2015, 1:36 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	Thomas Greiner 2015/01/12 10:37:54 License header and document type are missing License header and document type are missing Sebastian Noack 2015/01/12 11:55:07 You are right. I wasn't aware that we add the GPL Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > License header You are right. I wasn't aware that we add the GPL header also to HTML files. Show quoted text > and document type are missing It's optional in HTML5. And I personally prefer to omit. But it seems that we usually still specify the doctype declaration. So in favor of consistence, I added it. Thomas Greiner 2015/01/16 18:17:21 Thank you. Just one more thing: We changed the pro Show quoted text On 2015/01/12 11:55:07, Sebastian Noack wrote: > On 2015/01/12 10:37:54, Thomas Greiner wrote: > > License header > You are right. I wasn't aware that we add the GPL header also to HTML files. > > > and document type are missing > It's optional in HTML5. And I personally prefer to omit. But it seems that we > usually still specify the doctype declaration. So in favor of consistence, I > added it. Thank you. Just one more thing: We changed the protocol in the URL to "https" in the other license headers. Sebastian Noack 2015/02/04 14:17:29 Done. Show quoted text On 2015/01/16 18:17:21, Thomas Greiner wrote: > On 2015/01/12 11:55:07, Sebastian Noack wrote: > > On 2015/01/12 10:37:54, Thomas Greiner wrote: > > > License header > > You are right. I wasn't aware that we add the GPL header also to HTML files. > > > > > and document type are missing > > It's optional in HTML5. And I personally prefer to omit. But it seems that we > > usually still specify the doctype declaration. So in favor of consistence, I > > added it. > > Thank you. Just one more thing: We changed the protocol in the URL to "https" in > the other license headers. Done.
	2 <head>

	3 <link type="text/css" rel="stylesheet" href="skin/devtools-panel.css">

	4 <script type="application/javascript" src="ext/common.js"></script>
	Thomas Greiner 2015/01/12 10:37:54 Declaring the type attribute is no longer necessar Declaring the type attribute is no longer necessary Sebastian Noack 2015/01/12 11:55:07 Done. Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > Declaring the type attribute is no longer necessary Done.
	5 <script type="application/javascript" src="ext/devtools.js"></script>

	6 <script type="application/javascript" src="devtools-panel.js"></script>

	7 </head>

	8 <body>

	9 <div id="header">
	Thomas Greiner 2015/01/12 10:37:54 What about using <header> here instead? What about using <header> here instead? Thomas Greiner 2015/01/12 10:37:54 The structure is a bit scattered so instead of he The structure is a bit scattered so instead of header - table (contains selects as well as table headers) - tr - td div#items - table - tr - td footer I'd suggest to merge the two tables into a single one header (contains selects) table - thead (contains table headers) - tr - th - tbody#items - tr - td footer Sebastian Noack 2015/01/12 11:55:07 Done. Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > What about using <header> here instead? Done. Sebastian Noack 2015/01/12 11:55:07 Initially I used that structure. But flexbox requi Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > The structure is a bit scattered so instead of > > header > - table (contains selects as well as table headers) > - tr > - td > div#items > - table > - tr > - td > footer > > I'd suggest to merge the two tables into a single one > > header (contains selects) > table > - thead (contains table headers) > - tr > - th > - tbody#items > - tr > - td > footer Initially I used that structure. But flexbox requires an additional container around the the table header and content area. Thomas Greiner 2015/01/16 18:17:21 That's a pity and seems like that's also how the D Show quoted text On 2015/01/12 11:55:07, Sebastian Noack wrote: > On 2015/01/12 10:37:54, Thomas Greiner wrote: > > The structure is a bit scattered so instead of > > > > header > > - table (contains selects as well as table headers) > > - tr > > - td > > div#items > > - table > > - tr > > - td > > footer > > > > I'd suggest to merge the two tables into a single one > > > > header (contains selects) > > table > > - thead (contains table headers) > > - tr > > - th > > - tbody#items > > - tr > > - td > > footer > > Initially I used that structure. But flexbox requires an additional container > around the the table header and content area. That's a pity and seems like that's also how the DevTools implemented it so should be fine for us as well.
	10 <table>

	11 <tr>

	12 <td colspan="2">

	13 Show

	14 <select id="filter-state">

	15 <option value="">all</option>

	16 <option>blocked</option>

	17 <option>whitelisted</option>

	18 </select>

	19 items of

	20 <select id="filter-type">

	21 <option value="">any</option>

	22 <option>SUBDOCUMENT</option>

	23 <option>IMAGE</option>

	24 <option>STYLESHEET</option>

	25 <option>SCRIPT</option>

	26 <option>OBJECT</option>

	27 <option>XMLHTTPREQUEST</option>

	28 <option>POPUP</option>

	29 <option>ELEMHIDE</option>

	30 <option>OTHER</option>
	Thomas Greiner 2015/01/12 10:37:54 I noticed that we also offer the following content I noticed that we also offer the following content types: - OBJECT_SUBREQUEST - MEDIA - FONT Any reason why not to include them? Sebastian Noack 2015/01/12 11:55:07 We don't have those types on Chrome/Opera/Safari. Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > I noticed that we also offer the following content types: > > - OBJECT_SUBREQUEST > - MEDIA > - FONT > > Any reason why not to include them? We don't have those types on Chrome/Opera/Safari.
	31 </select>

	32 type

	33 </td>

	34 </tr>

	35 <tr>

	36 <td>

	37 <div class="request-wrapper">

	38 <div class="url">Request</div>

	39 <div class="domain">Document domain</div>

	40 <div class="type">Type</div>

	41 </div>

	42 </td>

	43 <td>

	44 <div class="filter-wrapper">

	45 <div class="filter">Filter</div>

	46 <div class="origin">Origin</div>

	47 </div>

	48 </td>

	49 </tr>

	50 </table>

	51 </div>

	52 <div id="items">

	53 <table></table>

	54 </div>

	55 <div id="footer">
	Thomas Greiner 2015/01/12 10:37:54 Same here with the <footer> tag Same here with the <footer> tag Sebastian Noack 2015/01/12 11:55:07 Done. Show quoted text On 2015/01/12 10:37:54, Thomas Greiner wrote: > Same here with the <footer> tag Done.
	56 <a id="reload">Reload</a> page to see effect of filter changes

	57 </div>

	58 </body>

	59 </html>

OLD	NEW

« no previous file with comments | « no previous file | devtools-panel.js » ('j') | devtools-panel.js » ('J')