Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: devtools-panel.html

Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome (Closed)
Patch Set: Created Jan. 7, 2015, 1:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | devtools-panel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devtools-panel.html
===================================================================
new file mode 100644
--- /dev/null
+++ b/devtools-panel.html
@@ -0,0 +1,59 @@
+<html>
Thomas Greiner 2015/01/12 10:37:54 License header and document type are missing
Sebastian Noack 2015/01/12 11:55:07 You are right. I wasn't aware that we add the GPL
Thomas Greiner 2015/01/16 18:17:21 Thank you. Just one more thing: We changed the pro
Sebastian Noack 2015/02/04 14:17:29 Done.
+ <head>
+ <link type="text/css" rel="stylesheet" href="skin/devtools-panel.css">
+ <script type="application/javascript" src="ext/common.js"></script>
Thomas Greiner 2015/01/12 10:37:54 Declaring the type attribute is no longer necessar
Sebastian Noack 2015/01/12 11:55:07 Done.
+ <script type="application/javascript" src="ext/devtools.js"></script>
+ <script type="application/javascript" src="devtools-panel.js"></script>
+ </head>
+ <body>
+ <div id="header">
Thomas Greiner 2015/01/12 10:37:54 What about using <header> here instead?
Thomas Greiner 2015/01/12 10:37:54 The structure is a bit scattered so instead of he
Sebastian Noack 2015/01/12 11:55:07 Done.
Sebastian Noack 2015/01/12 11:55:07 Initially I used that structure. But flexbox requi
Thomas Greiner 2015/01/16 18:17:21 That's a pity and seems like that's also how the D
+ <table>
+ <tr>
+ <td colspan="2">
+ Show
+ <select id="filter-state">
+ <option value="">all</option>
+ <option>blocked</option>
+ <option>whitelisted</option>
+ </select>
+ items of
+ <select id="filter-type">
+ <option value="">any</option>
+ <option>SUBDOCUMENT</option>
+ <option>IMAGE</option>
+ <option>STYLESHEET</option>
+ <option>SCRIPT</option>
+ <option>OBJECT</option>
+ <option>XMLHTTPREQUEST</option>
+ <option>POPUP</option>
+ <option>ELEMHIDE</option>
+ <option>OTHER</option>
Thomas Greiner 2015/01/12 10:37:54 I noticed that we also offer the following content
Sebastian Noack 2015/01/12 11:55:07 We don't have those types on Chrome/Opera/Safari.
+ </select>
+ type
+ </td>
+ </tr>
+ <tr>
+ <td>
+ <div class="request-wrapper">
+ <div class="url">Request</div>
+ <div class="domain">Document domain</div>
+ <div class="type">Type</div>
+ </div>
+ </td>
+ <td>
+ <div class="filter-wrapper">
+ <div class="filter">Filter</div>
+ <div class="origin">Origin</div>
+ </div>
+ </td>
+ </tr>
+ </table>
+ </div>
+ <div id="items">
+ <table></table>
+ </div>
+ <div id="footer">
Thomas Greiner 2015/01/12 10:37:54 Same here with the <footer> tag
Sebastian Noack 2015/01/12 11:55:07 Done.
+ <a id="reload">Reload</a> page to see effect of filter changes
+ </div>
+ </body>
+</html>
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | devtools-panel.js » ('J')

Powered by Google App Engine
This is Rietveld