messageResponder.js - Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: messageResponder.js

Issue 5646124035604480: Issue 154 - Added UI for devtools panel on Chrome (Closed)

Patch Set: Rebased and adapted for API changes Created March 12, 2015, 4:08 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: messageResponder.js

===================================================================

--- a/messageResponder.js

+++ b/messageResponder.js

@@ -24,7 +24,6 @@

var FilterStorage = require("filterStorage").FilterStorage;

var FilterNotifier = require("filterNotifier").FilterNotifier;

var defaultMatcher = require("matcher").defaultMatcher;

- var BlockingFilter = require("filterClasses").BlockingFilter;

var Synchronizer = require("synchronizer").Synchronizer;

var subscriptionClasses = require("subscriptionClasses");

@@ -32,6 +31,10 @@

var DownloadableSubscription = subscriptionClasses.DownloadableSubscription;

var SpecialSubscription = subscriptionClasses.SpecialSubscription;

+ var filterClasses = require("filterClasses");

+ var Filter = filterClasses.Filter;

+ var BlockingFilter = filterClasses.BlockingFilter;

var subscriptionKeys = ["disabled", "homepage", "lastSuccess", "title", "url", "downloadStatus"];

function convertSubscription(subscription)

{

@@ -142,6 +145,12 @@

var filter = defaultMatcher.matchesAny(message.url, message.requestType, message.docDomain, message.thirdParty);

callback(filter instanceof BlockingFilter);

break;

+ case "filters.add":

+ FilterStorage.addFilter(Filter.fromText(message.filter));

+ break;

+ case "filters.remove":

+ FilterStorage.removeFilter(Filter.fromText(message.filter));

+ break;

case "subscriptions.toggle":

var subscription = Subscription.fromURL(message.url);

if (subscription.url in FilterStorage.knownSubscriptions && !subscription.disabled)