Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5650509725696000: Issue 261 - FilterNotifier doesn`t support listeners removing themselves when triggered (Closed)

Created:
April 4, 2014, 12:46 p.m. by Wladimir Palant
Modified:
April 7, 2014, 12:04 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 261 - FilterNotifier doesn`t support listeners removing themselves when triggered

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/content/tests/filterNotifier.js View 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 2
Wladimir Palant
April 4, 2014, 12:46 p.m. (2014-04-04 12:46:28 UTC) #1
Thomas Greiner
April 7, 2014, 8:30 a.m. (2014-04-07 08:30:49 UTC) #2
LGTM with nits addressed

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
File chrome/content/tests/filterNotifier.js (right):

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
chrome/content/tests/filterNotifier.js:63: let listener1 = function(){
Nit: Move bracket to new line

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
chrome/content/tests/filterNotifier.js:73: })
Nit: Missing semicolon

Powered by Google App Engine
This is Rietveld