Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(375)

Issue 5650509725696000: Issue 261 - FilterNotifier doesn`t support listeners removing themselves when triggered (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Wladimir Palant
Modified:
5 years, 9 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 261 - FilterNotifier doesn`t support listeners removing themselves when triggered

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/content/tests/filterNotifier.js View 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 2
Wladimir Palant
5 years, 9 months ago (2014-04-04 12:46:28 UTC) #1
Thomas Greiner
5 years, 9 months ago (2014-04-07 08:30:49 UTC) #2
LGTM with nits addressed

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
File chrome/content/tests/filterNotifier.js (right):

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
chrome/content/tests/filterNotifier.js:63: let listener1 = function(){
Nit: Move bracket to new line

http://codereview.adblockplus.org/5650509725696000/diff/5629499534213120/chro...
chrome/content/tests/filterNotifier.js:73: })
Nit: Missing semicolon
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5