Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/init.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 let {Prefs} = require("prefs");
 let {FilterNotifier} = require("filterNotifier");
 
 let prefsInitDone = false;
 let filtersInitDone = false;
 
 function checkInitialized()
 {
   if (prefsInitDone && filtersInitDone)
   {
     checkInitialized = function() {};
-    _triggerEvent("init", require("filterStorage").FilterStorage.firstRun);
+    _triggerEvent("init", (!!firstRunDisabled ? false : require("filterStorage").FilterStorage.firstRun));

[Eric, 2015/05/15 19:36:13]

I don't think this works correctly, or if it does, it's not at all clear why.

First-run does both initialization of filter lists into storage and display of a
UI element (display of the first run page). As I understand our requirement, we
only want to suppress the UI element, not the other initialization. The way this
statement is written, it suppress both actions.

[Felix Dahlke, 2015/05/28 20:42:56]

Yes, I'm afraid we'll have to respect the suppress_first_run_page pref (that's
how it's called on Firefox and Chrome) in the client code, i.e. in IE :/

   }
 }
 
 Prefs._initListener = function()
 {
   prefsInitDone = true;
   checkInitialized();
 };
 
 FilterNotifier.addListener(function(action)
@@ skipping 23 matching lines @@
         subscription.homepage = node.homepage;
         if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
           Synchronizer.execute(subscription);
       }
     }
 
     filtersInitDone = true;
     checkInitialized();
   }
 });