Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 23 matching lines @@
   subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
   documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%",
   update_url_release: "https://update.adblockplus.org/%NAME%/update.json?type=%TYPE%",
   update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?type=%TYPE%",
   update_last_check: 0,
   update_last_error: 0,
   update_soft_expiration: 0,
   update_hard_expiration: 0,
   currentVersion: "0.0",
   notificationdata: {},
-  notificationurl: "https://notification.adblockplus.org/notification.json"
+  notificationurl: "https://notification.adblockplus.org/notification.json",
+  suppress_first_run_page: false,
+  disable_auto_updates: false
 };
 
+let preconfigurable = ["suppress_first_run_page", "disable_auto_updates"];
+
 let values = Object.create(defaults);
 let path = _fileSystem.resolve("prefs.json");
 let listeners = [];
 let isDirty = false;
 let isSaving = false;
 
 function defineProperty(key)
 {
   Object.defineProperty(Prefs, key,
   {
@@ skipping 67 matching lines @@
   },
 
   removeListener: function(listener)
   {
     let index = listeners.indexOf(listener);
     if (index >= 0)
       listeners.splice(index, 1);
   },
 };
 
+// Update the default prefs with what was preconfigured
+for (let key in _preconfiguredPrefs)
+  if (preconfigurable.indexOf(key) != -1)
+    defaults[key] = _preconfiguredPrefs[key];
+
+// Define defaults
 for (let key in defaults)
   defineProperty(key);
 
+// Set values of prefs based on _preconfiguredPrefs
+for (let key in _preconfiguredPrefs)

[Felix Dahlke, 2015/06/12 12:37:08]

Two things and we're done:

1. Turn the `let values = Object.create(defaults);` above into a simple
declaration, i.e. `let values;`
2. Get rid of this loop and just do: `values = Object.create(defaults);`
instead.

[Oleksandr, 2015/06/17 13:27:41]

Done. Miss-understood your intent before.

+{
+  if (preconfigurable.indexOf(key) != -1)
+  {
+    values[key] = _preconfiguredPrefs[key];
+  }
+}
+
 load();