Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 23 matching lines @@
   subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
   documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%",
   update_url_release: "https://update.adblockplus.org/%NAME%/update.json?type=%TYPE%",
   update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?type=%TYPE%",
   update_last_check: 0,
   update_last_error: 0,
   update_soft_expiration: 0,
   update_hard_expiration: 0,
   currentVersion: "0.0",
   notificationdata: {},
-  notificationurl: "https://notification.adblockplus.org/notification.json"
+  notificationurl: "https://notification.adblockplus.org/notification.json",
+  suppress_first_run_page: false,
+  disable_auto_updates: false
+};
+
+let isPreconfigurable = {

[Felix Dahlke, 2015/06/11 20:21:13]

I'd prefer this to work the same way as in Firefox, namely:

let preconfigurable = ["suppress_first_run_page", "disable_auto_updates"];

[Oleksandr, 2015/06/12 10:47:57]

Done.

+  suppress_first_run_page: true, 
+  disable_auto_updates: true
 };
 
 let values = Object.create(defaults);
 let path = _fileSystem.resolve("prefs.json");
 let listeners = [];
 let isDirty = false;
 let isSaving = false;
 
 function defineProperty(key)
 {
@@ skipping 13 matching lines @@
 
       for (let listener of listeners)
         listener(key);
     },
     enumerable: true
   });
 }
 
 function load()
 {
+  // Set default prefs based on _preconfiguredPrefs
+  for (let key in _preconfiguredPrefs)
+  {
+    if (isPreconfigurable[key])
+    {
+      values[key] = _preconfiguredPrefs[key];

[Eric, 2015/06/10 17:48:16]

Shouldn't this first check to see if there is a preconfiguration preference
stated? As written, this will overwrite ones that are not so stated with 'null'.

[Felix Dahlke, 2015/06/11 20:21:13]

Yes, should be: `if (key in _preconfiguredPrefs && preconfigurable.indexOf(key)
!= -1)`

[Oleksandr, 2015/06/12 07:36:14]

Hm, am I missing something? I don't see why would it override with 'null'. This
is in a loop that iterates only through preconfiguration preferences. It will
override only those that were preconfigured... Worst case it can also iterate
through inherited properties of _preconfiguredPrefs (if any), but those are not
in the whitelist. 

[Felix Dahlke, 2015/06/12 07:55:03]

Yes you're right, guess me and Eric both missed that above :P

+    }
+  }
+
   _fileSystem.read(path, function(result)
   {
     // prefs.json is expected to be missing, ignore errors reading file
     if (!result.error)
     {
       try
       {
         let data = JSON.parse(result.content);
         for (let key in data)
           if (key in defaults)
@@ skipping 40 matching lines @@
     let index = listeners.indexOf(listener);
     if (index >= 0)
       listeners.splice(index, 1);
   },
 };
 
 for (let key in defaults)
   defineProperty(key);
 
 load();