Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 116 matching lines @@
   params.push_back(shared_from_this());
   JsValuePtr result = func->Call(params);
   return result->AsBool();
 }
 
 bool Subscription::operator==(const Subscription& subscription) const
 {
   return GetProperty("url")->AsString() == subscription.GetProperty("url")->AsString();
 }
 
-FilterEngine::FilterEngine(JsEnginePtr jsEngine)
+FilterEngine::FilterEngine(JsEnginePtr jsEngine, 
+  std::map<std::string, AdblockPlus::JsValuePtr> preconfiguredPrefs)
     : jsEngine(jsEngine), initialized(false), firstRun(false), updateCheckId(0)
 {
   jsEngine->SetEventCallback("init", std::tr1::bind(&FilterEngine::InitDone,
       this, std::tr1::placeholders::_1));
 
   {
     // Lock the JS engine while we are loading scripts, no timeouts should fire
     // until we are done.
     const JsContext context(jsEngine);
+
+    // Set the preconfigured prefs
+    JsValuePtr preconfiguredPrefsObject = jsEngine->NewObject();
+    for (std::map<std::string, AdblockPlus::JsValuePtr>::iterator it = 
+         preconfiguredPrefs.begin(); 
+         it != preconfiguredPrefs.end(); it++)
+    {
+      preconfiguredPrefsObject->SetProperty(it->first, it->second);
+    }
+    JsValuePtr globalJsObject = jsEngine->GetGlobalJsObject();
+    globalJsObject->SetProperty("_preconfiguredPrefs", preconfiguredPrefsObject);

[Eric, 2015/06/10 17:48:16]

Apart from initialization (where 'GetGlobalJsObject' isn't needed), this is the
only place where 'GetGlobalJsObject' is used. It would be just as good to define
'JsEngine::SetGlobalProperty'. Properties are only read out in JavaScript code,
so there's no need for a corresponding "Get..." version.

[Felix Dahlke, 2015/06/11 20:21:13]

For the record: I asked for it this way. But Eric's got a point, that would
simplify things a bit, and I suppose we don't have to be overly general purpose
here.

Either way, I think we want to have a test for this in test/JsEngine.cpp.

[Oleksandr, 2015/06/12 10:47:57]

Done.

+
+    // Load adblockplus scripts
     for (int i = 0; !jsSources[i].empty(); i += 2)
       jsEngine->Evaluate(jsSources[i + 1], jsSources[i]);
   }
 
   // TODO: This should really be implemented via a conditional variable
   while (!initialized)
     ::Sleep(10);
 }
 
 namespace
@@ skipping 258 matching lines @@
 }
 
 int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2)
 {
   JsValueList params;
   params.push_back(jsEngine->NewValue(v1));
   params.push_back(jsEngine->NewValue(v2));
   JsValuePtr func = jsEngine->Evaluate("API.compareVersions");
   return func->Call(params)->AsInt();
 }