Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

include/AdblockPlus/JsEngine.h

Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -211,6 +211,13 @@
      */
     void SetLogSystem(LogSystemPtr val);
 
+    /**
+    * Sets a global property that can be accessed by all the scripts.

[Felix Dahlke, 2015/06/17 18:49:24]

Nit: Seems like the indentation is off here, should be one more space in front
of the stars.

[Oleksandr, 2015/06/17 23:53:27]

Done.

+    * @param The `std::string` name of the property to set

[Felix Dahlke, 2015/06/17 18:49:24]

Nit: Don't think Doxygen will parse this as intended, should rather be:

@param name Name of the property to set.
@param value Value of the property to set.

(Also left out the types since Doxygen adds those automatically.)

[Oleksandr, 2015/06/17 23:53:27]

Done. It would still produce understandable output either way, however there was
a warning, you're right. In fact Doxygen build throws a lot of warnings, but
we've agreed before to keep it casual, IIRC.

+    * @param The `JsValuePtr` value of the property to set
+    */
+    void SetGlobalProperty(std::string name, AdblockPlus::JsValuePtr value);

[Felix Dahlke, 2015/06/17 18:49:24]

Nit: The std::string should be passed as a const reference.

[Oleksandr, 2015/06/17 23:53:28]

Done.

+
   private:
     JsEngine();
 
@@ -220,6 +227,7 @@
     v8::Isolate* isolate;
     V8ValueHolder<v8::Context> context;
     EventMap eventCallbacks;
+    JsValuePtr globalJsObject;
   };
 }