Issue 2325 - Add a way to set settings in libadblockplus for FRP and automatic updates

lib/updater.js

Index: lib/updater.js
===================================================================
--- a/lib/updater.js
+++ b/lib/updater.js
@@ -36,6 +36,10 @@
 
 function getDownloadable(forceCheck)
 {
+  if (!forceCheck && Pref.disable_auto_updates)

[Eric, 2015/06/19 15:23:37]

This comment is actually in response to a previous patch set. Consider this a
continuation.

I still don't care for "disable_" as a prefix for these preference names. The
real problem I have, I've figured out, is that these identifiers are named with
respect their default values, not what they actually do. I suggested
"enable_auto_updates" before, but that's wrong as well.

What would be better is "perform_auto_updates". It would update to "true", but
no one would need to care what the default was when looking at the statement
above:

  if (!(forceCheck || Pref.performAutoUpdate))
  {
    return null;
  }

[Felix Dahlke, 2015/06/22 07:33:58]

I suppose this was named in line with "suppress_first_run_page". Either
"disable_auto_updates" or "perform_auto_updates" is fine by me, both obvious
enough to me.

[Oleksandr, 2015/06/22 07:47:11]

By this logic, we'll also have to rename the suppress_first_run to something
like display_first_run. But we are trying to be as consistent across browsers as
possible, and since we already have suppress_first_run in Chrome - I'd leave
this as is too. Also, if there was a performAutoUpdate setting, it would be more
ambivalent - should set it to true JIC, or not? Right now it is pretty
straightforward that I should set this only if I want to disable the auto
updates.

[Eric, 2015/06/25 17:44:40]

That's right.
The same argument I've made applies to Chrome, too. It's not a great idea to
name variables for behavior after their default values.
I didn't make this comment to insist upon renaming the variable so much as to
capture my insight about why I disliked the variable name. I'm fine with leaving
the names as is.
Yes, you set it to true. Explicit default values should be present for every
preference. To do otherwise is asking for trouble down the road.

+  {
+    return null;
+  }
   let url = updateUrl.replace(/%TYPE%/g, forceCheck ? TYPE_MANUAL : TYPE_AUTOMATIC);
   let downloadable = new Downloadable(url);
   downloadable.lastError = Prefs.update_last_error;